Fix glooctl check test flake #10615
Merged
Fix glooctl check test flake #10615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
|
Visit the preview URL for this PR (updated for commit 4757ecc): https://gloo-edge--pr10615-fix-glooctl-check-te-ze2483zb.web.app (expires Fri, 21 Feb 2025 18:42:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
davidjumani
approved these changes
Feb 14, 2025
nfuden
reviewed
Feb 14, 2025
Comment on lines
55
to
59
| if len(metrics) == 0 { | ||
| fmt.Println("No xds metrics to check") | ||
| } else { | ||
| fmt.Println("OK") | ||
| } |
There was a problem hiding this comment.
This will break glooctl output types right? I think we do that in the out of sync but this will make it always escape the output formats
nfuden
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR excludes the xds-metrics check from glooctl check runs in the e2e glooctl check tests suite to fix enterprise tests that are flaking due to an Envoy bug.
An in-depth explanation and additional context can be found here.
Testing steps
I verified this fix by running the failing enterprise tests on my local and seeing them pass consistently with the fix.
Additional changes
I also made a small improvement to the user-facing
glooctl checkoutput.If the deployments are not all healthy, the previous output would include:
With this change, it will instead include:
If the check has no issues, it will include:
With an open source installation, it will instead include:
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature works