아레나 업데이트 반영 #63
Closed
아레나 업데이트 반영 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanolP
requested changes
Oct 1, 2023
| - arenaRating | ||
| - arenaMaxTier | ||
| - arenaMaxRating | ||
| - arenaCompetedRoundCount |
There was a problem hiding this comment.
arenaCompetedRoundCount가 여기서는 명시되어 있는데 실제 프로퍼티 설명은 없어요. 추가해주세요.
| paths: | ||
| Path: | ||
| get: | ||
| summary: 아레나 목록 가져오기 |
There was a problem hiding this comment.
Suggested change
| summary: 아레나 목록 가져오기 | |
| summary: 사용자가 참여한 아레나 목록 가져오기 |
summary가 다른 API route와 중복되지 않는 게 살펴보기에 좋을 것 같아요.
| description: "사용자가 참여한 아레나 목록입니다." | ||
| type: "array" | ||
| items: | ||
| $ref: "../../schemas/arena.yaml#/components/schemas/Arena" |
There was a problem hiding this comment.
응답 형식이 변경되었어요. UserArenaDiff 등의 새로운 타입을 필요로 할 것 같아요.
| @@ -149,3 +154,23 @@ components: | |||
| type: "integer" | |||
| format: "int64" | |||
| example: 104 | |||
| arenaTier: | |||
| description: "문제 목록입니다." | ||
| type: "array" | ||
| items: | ||
| $ref: "../../schemas/arena.yaml#/components/schemas/Arena" |
There was a problem hiding this comment.
이 API 응답에서는 isRegistered 필드가 존재해요. 추가해주세요.
| type: "boolean" | ||
| example: true | ||
| languages: | ||
| description: "아레나에서 사용할 수 있는 언어의 목록입니다." |
There was a problem hiding this comment.
Suggested change
| description: "아레나에서 사용할 수 있는 언어의 목록입니다." | |
| description: "아레나 문제 본문 등에 사용된 자연어 목록입니다." |
프로그래밍 언어로 설명을 착각하기 쉬워보여요. 아레나 문제 본문의 언어임을 설명하는 게 더 좋을 듯 해요.
|
이 PR은 #67 머지 이후 TypeSpec으로 마이그레이션한 다음 머지할게요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
#62 아레나 업데이트 이후 새로이 추가된 스킴과 엔드포인트를 반영하였습니다.
변경 사항