Skip to content

Commit

Permalink
move google-cloud/dlp to peer dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
Torgny Bjers committed May 15, 2019
1 parent 4bcc638 commit fad9d5b
Show file tree
Hide file tree
Showing 4 changed files with 113 additions and 97 deletions.
11 changes: 8 additions & 3 deletions .github/main.workflow
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,18 @@ workflow "Verify the module" {
}

action "install" {
uses = "actions/npm@1.0.0"
uses = "actions/npm@master"
args = "ci"
}

action "peer_install" {
uses = "actions/npm@master"
args = "install --no-save @google-cloud/dlp"
}

action "verify_all" {
needs = "install"
uses = "actions/npm@1.0.0"
needs = "peer_install"
uses = "actions/npm@master"
args = "run verify_all"
}

Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,8 @@ Note that Google Cloud DLP already also provides a node.js library (https://www.
- it is easy to add custom patterns or rules to redact-pii
- `GoogleDLPRedactor` uses the `.inspectContent` instead of `.deidentifyContent` method of `@google-cloud/dlp` which has a pricing advantage for large scale redaction scenarios since you will be only charged "Inspection Units" and no additional "Transformation Units" (see https://cloud.google.com/dlp/pricing) . redact-pii only uses DLP to `identify` PII but does the replacement `transformation` by itself which saves you some 💰💰💰.

In order to use Google Data Loss Prevention you must install the peer dependency yourself with `npm install --save @google-cloud/dlp` since we are no longer bundling it with this package.

#### Use Google Data Loss Prevention only (this won't make use of redact-pii's built-in regex patterns)

1. Prequesites:
Expand Down
Loading

0 comments on commit fad9d5b

Please sign in to comment.