Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored code base and fixed some code #171

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

refactored code base and fixed some code #171

wants to merge 6 commits into from

Conversation

rjoydip-zz
Copy link

@rjoydip-zz rjoydip-zz commented Mar 30, 2020

This PR contains below things.

rjoydip added 2 commits March 30, 2020 02:22
…e refactor. Used async/await fix(logger): depedent on PR #167 refactor(next.config): Configuration of next.js enhanced feat(mock): created new folder mock inside _test_ folder
@vercel
Copy link

vercel bot commented Mar 30, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/someshkar/covid19india-network/ldlruk1u8
✅ Preview: https://covid19india-network-git-fork-rjoydip-refactor-1.someshkar.now.sh

@someshkar
Copy link
Owner

Hey @rjoydip, while this works, can you make incremental changes rather than changing 4000 lines of code in a single PR? It really helps keep track in the commit history. Moreover, there's a merge conflict at the moment, do look into this.

@rjoydip-zz
Copy link
Author

rjoydip-zz commented Apr 21, 2020

@someshkar Sorry for the delay. Conflict resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants