Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect IP in SONiC-DASH HLD VNET to VNET example. #459

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix incorrect IP in SONiC-DASH HLD VNET to VNET example. #459

merged 1 commit into from
Nov 21, 2023

Conversation

r12f
Copy link
Collaborator

@r12f r12f commented Nov 11, 2023 •
edited
Loading

This PR is for issue #452.

The IP is incorrectly placed there. From the DASH policy below, the right IP is 10.1.1.1.

  {
        "DASH_VNET_MAPPING_TABLE:Vnet1:10.1.1.1": {
            "routing_type":"vnet_encap",
            "underlay_ip":"101.1.2.3",
            "mac_address":"F9-22-83-99-22-A2",
	    "metering_class":"1001"
        },
        "OP": "SET"
    },

@r12f r12f requested a review from mgheorghe November 11, 2023 01:04
@r12f r12f mentioned this pull request Nov 11, 2023
Closed
@mgheorghe
Copy link
Collaborator

now it looks good

@KrisNey-MSFT
Copy link
Collaborator

Merging

@KrisNey-MSFT KrisNey-MSFT merged commit 572fbb1 into sonic-net:main Nov 21, 2023
2 checks passed
@r12f r12f deleted the user/r12f/hldfix branch November 29, 2023 06:30
clarklee-guizhao added a commit to clarklee-guizhao/DASH that referenced this pull request Dec 3, 2023
@clarklee-guizhao
Merge branch 'main' into nat-hld
d5e6a83 
* main: (75 commits)
  [dash-SAI] Enable warnings as errors (sonic-net#466)
  [SAI] wrong code generated in libsai sonic-net#415 (sonic-net#463)
  Fix incorrect IP in SONiC-DASH HLD VNET to VNET example. (sonic-net#459)
  DASH pipeline packet flow update proposal. (sonic-net#449)
  [libsai] Add attr name logging when doing get api (sonic-net#451)
  Build libsai deb packages in github workflow (sonic-net#450)
  Add Private Link mapping (sonic-net#327)
  [SAI] Update SAI submodule to the latest origin/master (sonic-net#446)
  [dash] Add libsai-debs target to create libsai debian packages (sonic-net#444)
  update p4 compile dependancy to avoid parallel  docker runs (sonic-net#443)
  [dash] Refactor libsai (sonic-net#438)
  [dash] Update SAI to latest v1.13 (sonic-net#435)
  [dash-pipeline] Refactor Makefiles (sonic-net#432)
  Remove ACL tags from BM (sonic-net#425)
  [submodule] Update SAI submodule to origin/master (sonic-net#431)
  [sai-api-gen] Write files only when changes are detected (sonic-net#429)
  Adds SAI_ROUTE_ENTRY_ATTR_PACKET_ACTION api to dash_underlay_routing (sonic-net#422)
  [SAI] Add missing check for api initialized
  [SAI] Print oids in hex form
  [SAI] Change asserts to return error codes and add missing switch api
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgheorghe mgheorghe mgheorghe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r12f @mgheorghe @KrisNey-MSFT