Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename is_*_v4_or_v6 to *_is_v6. #472

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Conversation

r12f
Copy link
Collaborator

@r12f r12f commented Dec 8, 2023

This makes code more explicit on 0 = v4 and 1 = v6.

This change will not change any generated code. Here is the diff for proof. Only comment update after make:

r12f@r12f-dl380:~/data/code/sonic/DASH/dash-pipeline
$ diff SAI/SAI/experimental/ ~/data/code/sonic/DASH-exp/dash-pipeline/SAI/SAI/experimental/

$ diff SAI/lib ~/data/code/sonic/DASH-exp/dash-pipeline/SAI/lib/
diff SAI/lib/saidashoutboundcatopa.cpp /home/r12f/data/code/sonic/DASH-exp/dash-pipeline/SAI/lib/saidashoutboundcatopa.cpp
47c47
<         // set is_ipv6_field_id field
---
>         // set v4_or_v6 field
241c241
<         // set is_ipv6_field_id field
---
>         // set v4_or_v6 field
diff SAI/lib/saidashoutboundrouting.cpp /home/r12f/data/code/sonic/DASH-exp/dash-pipeline/SAI/lib/saidashoutboundrouting.cpp
45c45
<         // set is_ipv6_field_id field
---
>         // set v4_or_v6 field
136c136
<                     // set is_ipv6_field_id field
---
>                     // set v4_or_v6 field
151c151
<                     // set is_ipv6_field_id field
---
>                     // set v4_or_v6 field
166c166
<                     // set is_ipv6_field_id field
---
>                     // set v4_or_v6 field
181c181
<                     // set is_ipv6_field_id field
---
>                     // set v4_or_v6 field
196c196
<                     // set is_ipv6_field_id field
---
>                     // set v4_or_v6 field
211c211
<                     // set is_ipv6_field_id field
---
>                     // set v4_or_v6 field
226c226
<                     // set is_ipv6_field_id field
---
>                     // set v4_or_v6 field
328c328
<         // set is_ipv6_field_id field
---
>         // set v4_or_v6 field

@chrispsommers chrispsommers self-requested a review December 9, 2023 01:11
Copy link
Collaborator

@chrispsommers chrispsommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r12f
Copy link
Collaborator Author

r12f commented Dec 9, 2023

Thanks a lot for the quick review, Marian and Chris!

@r12f r12f merged commit c06909c into sonic-net:main Dec 9, 2023
@r12f r12f deleted the user/r12f/sai-gen-update branch December 9, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants