[sai-gen] Refactor the templates of libsai implementation #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@r12f for viz |
r12f
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Reviewed and sync'ed offline. This PR is refactor only and trying to target no changes in the libsai, hence many issues are not addressed, such as per action parameters, duplicated code for setting P4 values and bulk entry creation and removals. These issues are intended to be addressed in later changes, so we can avoid building too large PR to review.
|
@r12f would you like for me to merge it today? |
|
breaks libsai templates into smaller ones; want to be mindful of compatibility; will generate separate PRs for forward movement |
r12f
pushed a commit
that referenced
this pull request
Dec 23, 2024
Following #648, continue to refactor libsai implementation for easier read and maintenance: 1. Avoid using compilated j2 template as best 2. Use c++ code directly to express the logic of API implementation, based on p4 table metadata info (p4meta.[h, cpp]) 3. Implement APIs set/get attribute by using common `DashSai::set` and `DashSai::get`, which fix the issue #650 4. Update libsai test (vnet_out.cpp) to cover sanity test of APIs set/get attribute Note: To refactor APIs create/remove with current approach in next PR. The generated sample code of APIs set/get attribute is as below: - SAI object objectID  p4meta `outbound_routing_group_meta_table` definition  - SAI object entry  p4meta `outbound_routing_entry_meta_table` definition 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base on #647, refactor the templates of libsai implementation
to make it more readable and maintainable. It replaces one single template
saiapi.cpp.j2with severalsmall templates under directory
SAI/templates/impls.The changes will not change any generated cpp code for sai api implementation: