[dash] add zmq_dpu_proxy_address_base parameter to telemetry.go #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Yakiv-Huryk
force-pushed
the
dash-zmq-proxy
branch
from
4d3df33 to
56790a0
Compare
This allows to configure the gnmi server to send the DASH configuration to the DashOffloadManager instead of the DPU
Yakiv-Huryk
force-pushed
the
dash-zmq-proxy
branch
from
56790a0 to
e107a88
Compare
oleksandrivantsiv
approved these changes
Dec 2, 2024
|
@qiluo-msft would you like to review as well? if looks good lets signoff and merge. this need to be in 202411 soon |
|
@oleksandrivantsiv is it also required for 202405 or no need? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
This allows to configure the gnmi server to send the DASH configuration to the DashOffloadManager instead of the DPU
How I did it
Added a new flag "zmq_dpu_proxy_address_base" to telemetry.go
How to verify it
Manual test
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)