Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GNMI service to limit API access by role #335

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

ganglyu
Copy link
Contributor

@ganglyu ganglyu commented Jan 7, 2025

Microsoft ADO: 30073317

Why I did it

GNMI/GNOI services need to support role in API operation. RO user is not allowed to call write API.

How I did it

We have supported common name to role mapping, and I have updated API authentication to verify role.

How to verify it

Run unit test and end to end test.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ganglyu
Copy link
Contributor Author

ganglyu commented Jan 7, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

gnmi_server/server.go Outdated Show resolved Hide resolved
liuh-80
liuh-80 previously approved these changes Jan 9, 2025
@mssonicbld
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ganglyu ganglyu merged commit aa547ad into sonic-net:master Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants