-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SaveStartupConfig for SaveOnSet feature #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on Sachin's approval.
A question - |
Updated CL with agreed upon method of using minimum version of rpc_copy |
Yes that would be the case. |
Its out-of-date with base branch, please merge the latest from sonic-net:master |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest commit is introducing many rpcs and options that are not really supported. This is not a clean approach. Approach of having a translib API would have been better -- copy r s is a standard operation in NOS world.
Anand>> Please have only the necessary RPC implemented end to end. Others will come in when Dell plans to bring it in. |
They are returning Unimplemented. Do you want them removed from the yang and annotation as well? Please be more specific, it seems as if Sachin is rejecting the whole concept of the compromise we all agreed on. |
Anand>>I meant only the RPC to perform config save needs to be implemented end to end all others will be implemented when Dell plans to bring it in. Other RPCs should not be in the YANG, annotation or the transformer implementation. |
Removed the requested stubs. I'm going to have to come back to this in a few days to figure out why the linter doesn't like removing them. |
Closing this PR as its no longer needed due to using sonic services client in sonic-net/sonic-gnmi#108 |
sonic-net/SONiC#1239