Add Multi ASIC GCU test cases for IDF and LinkCRC. #13210

xincunli-sonic · 2024-06-10T18:36:36Z

Description of PR

Summary:
Added Multi ASIC GCU test cases for IDF ISOLATION and LINK CRC MITIGATION.

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld · 2024-08-09T23:58:50Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/generic_config_updater/test_multiasic_scenarios.py fix end of files.........................................................Passed check yaml...............................................................Passed check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/generic_config_updater/test_multiasic_scenarios.py:7:1: F401 'tests.generic_config_updater.gu_utils.DEFAULT_CHECKPOINT_NAME' imported but unused tests/generic_config_updater/test_multiasic_scenarios.py:7:1: F401 'tests.generic_config_updater.gu_utils.replace' imported but unused tests/generic_config_updater/test_multiasic_scenarios.py:191:15: E128 continuation line under-indented for visual indent flake8...............................................(no files to check)Skipped ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2024-08-10T01:30:46Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/generic_config_updater/test_multiasic_scenarios.py fix end of files.........................................................Passed check yaml...............................................................Passed check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/generic_config_updater/test_multiasic_scenarios.py:191:13: E128 continuation line under-indented for visual indent flake8...............................................(no files to check)Skipped check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2024-08-10T22:42:00Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/generic_config_updater/test_multiasic_scenarios.py fix end of files.........................................................Failed - hook id: end-of-file-fixer - exit code: 1 - files were modified by this hook Fixing tests/generic_config_updater/test_multiasic_scenarios.py check yaml...............................................................Passed check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

tests/generic_config_updater/test_multiasic_scenarios.py

.azure-pipelines/pr_test_scripts.yaml

mssonicbld · 2024-08-19T17:26:19Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/generic_config_updater/test_multiasic_scenarios.py fix end of files.........................................................Passed check yaml...............................................................Passed check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Passed flake8...............................................(no files to check)Skipped check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

xincunli-sonic · 2024-08-19T18:30:43Z

/azpw run

mssonicbld · 2024-08-19T18:30:46Z

/AzurePipelines run

azure-pipelines · 2024-08-19T18:30:56Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2024-08-19T19:28:12Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/generic_config_updater/test_multiasic_scenarios.py fix end of files.........................................................Passed check yaml...............................................................Passed check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Passed flake8...............................................(no files to check)Skipped check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2024-10-07T18:24:07Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/generic_config_updater/test_multiasic_scenarios.py fix end of files.........................................................Passed check yaml...............................................................Passed check for added large files..............................................Passed check python ast.........................................................Failed - hook id: check-ast - exit code: 1 tests/generic_config_updater/gu_utils.py: failed parsing with CPython 3.10.12: Traceback (most recent call last): File "/home/AzDevOps/.cache/pre-commit/repo1unh257w/py_env-python3/lib/python3.10/site-packages/pre_commit_hooks/check_ast.py", line 21, in main ast.parse(f.read(), filename=filename) File "/usr/lib/python3.10/ast.py", line 50, in parse ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2024-10-07T18:31:39Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/generic_config_updater/test_multiasic_scenarios.py fix end of files.........................................................Failed - hook id: end-of-file-fixer - exit code: 1 - files were modified by this hook Fixing tests/generic_config_updater/gu_utils.py check yaml...............................................................Passed check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Passed flake8...............................................(no files to check)Skipped check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2024-10-07T18:40:50Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/generic_config_updater/test_multiasic_scenarios.py fix end of files.........................................................Failed - hook id: end-of-file-fixer - exit code: 1 - files were modified by this hook Fixing tests/generic_config_updater/gu_utils.py Fixing tests/generic_config_updater/test_multiasic_scenarios.py check yaml...............................................................Passed check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Passed flake8...............................................(no files to check)Skipped ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

tests/generic_config_updater/test_multiasic_scenarios.py

xincunli-sonic · 2024-11-18T00:35:59Z

/azpw run

mssonicbld · 2024-11-18T00:36:02Z

/AzurePipelines run

azure-pipelines · 2024-11-18T00:36:08Z

Pull request contains merge conflicts.

…unli-sonic/sonic-mgmt into xincun/add-multi-asic-tests

xincunli-sonic · 2024-11-23T22:50:29Z

/azpw run

mssonicbld · 2024-11-23T22:50:32Z

/AzurePipelines run

azure-pipelines · 2024-11-23T22:50:44Z

Azure Pipelines successfully started running 1 pipeline(s).

xincunli-sonic · 2024-11-26T22:42:29Z

/azpw run

mssonicbld · 2024-11-26T22:42:32Z

/AzurePipelines run

azure-pipelines · 2024-11-26T22:42:44Z

Azure Pipelines successfully started running 1 pipeline(s).

judyjoseph · 2024-12-03T17:57:02Z

tests/generic_config_updater/test_multiasic_scenarios.py

+
+logger = logging.getLogger(__name__)
+
+IDF_ISOLATION = [


I feel it is good to separate these test scenarios into two different test files eg: test_idf_isolation.py and test_link_crc.py. Each of these testfiles can support both single_asic and multi-asic platforms, either as two testcases or a single testcase.

Also in multi-asic platforms, we can have platforms with a single asic, 2 asic, 3 asics. We could take a random asic and generate the patch from a template? REF : #15185

judyjoseph · 2024-12-03T17:58:16Z

tests/generic_config_updater/test_multiasic_scenarios.py

+            logger.info("Patching process broken, the error output is {}".format(output['stdout']))
+            pytest_assert(False, "Patching process broken, the error output is {}").format(output['stdout'])
+
+        cmds = 'sonic-db-cli -n asic0 CONFIG_DB hget "BGP_DEVICE_GLOBAL|STATE" idf_isolation_state'


idf_isolation patch could be applied to a downlink LC which could have single asic alone. Can we cover that case as well ?

tjchadaga · 2024-12-03T18:47:09Z

tests/generic_config_updater/test_multiasic_scenarios.py

+        redis_value = duthost.shell(cmds, module_ignore_errors=False)['stdout']
+        pytest_assert(redis_value == expected_value, "Config IDF ISOLATION failed")
+
+        cmds = 'sonic-db-cli -n asic1 CONFIG_DB hget "BGP_DEVICE_GLOBAL|STATE" idf_isolation_state'


Could we check 'sudo idf_isolation status' as well? We might have to apply the same config on all asics for that though. May be have separate cases for isolated_no_export and isolated_withdraw_all?

mssonicbld · 2024-12-12T22:41:46Z

/azp run

azure-pipelines · 2024-12-12T22:41:58Z

Azure Pipelines successfully started running 1 pipeline(s).

xincunli-sonic · 2024-12-13T01:58:59Z

/azpw run

mssonicbld · 2024-12-13T01:59:01Z

/AzurePipelines run

azure-pipelines · 2024-12-13T01:59:12Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2024-12-13T17:47:04Z

/azp run

azure-pipelines · 2024-12-13T17:47:16Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2024-12-13T19:49:54Z

/azp run

azure-pipelines · 2024-12-13T19:50:07Z

Azure Pipelines successfully started running 1 pipeline(s).

Add Multi ASIC GCU test cases for IDF and LinkCRC.

5d5ca7a

xincunli-sonic marked this pull request as draft June 10, 2024 18:37

Add test into pr script

7b802af

xincunli-sonic marked this pull request as ready for review June 11, 2024 19:03

xincunli-sonic requested review from wen587, judyjoseph and tjchadaga June 11, 2024 19:03

xincunli-sonic and others added 2 commits June 11, 2024 16:15

Modify the test case to multiasic t1

7b2079b

Update test_multiasic_scenarios.py

a649abf

Update test_multiasic_scenarios.py

b764882

fix format

1851913

wen587 reviewed Aug 12, 2024

View reviewed changes

tests/generic_config_updater/test_multiasic_scenarios.py Outdated Show resolved Hide resolved

.azure-pipelines/pr_test_scripts.yaml Outdated Show resolved Hide resolved

fix format

04a61b8

xincunli-sonic mentioned this pull request Aug 27, 2024

Add scope into JSON patch of existing GCU testcases for Multi ASIC. #14098

Merged

8 tasks

xincunli-sonic added 2 commits October 7, 2024 11:15

Add PORT table as ignored.

8a98fbf

Merge from master

b013a22

Merge from master

a62f89b

Remove trailing space.

0c74b3b

wen587 reviewed Oct 8, 2024

View reviewed changes

tests/generic_config_updater/test_multiasic_scenarios.py Outdated Show resolved Hide resolved

xincunli-sonic and others added 3 commits November 17, 2024 16:37

Merge branch 'master' into xincun/add-multi-asic-tests

f250cc3

Add Debug log

d24ffa7

Merge branch 'xincun/add-multi-asic-tests' of https://github.com/xinc…

6f76117

…unli-sonic/sonic-mgmt into xincun/add-multi-asic-tests

xincunli-sonic requested a review from qiluo-msft December 2, 2024 22:07

qiluo-msft previously approved these changes Dec 3, 2024

View reviewed changes

judyjoseph reviewed Dec 3, 2024

View reviewed changes

tjchadaga reviewed Dec 3, 2024

View reviewed changes

Address comments.

4819365

xincunli-sonic dismissed qiluo-msft’s stale review via 4819365 December 12, 2024 22:41

Add test to multi-asic-t1-lag

a16e39d

fix verify linkcrc member

deb5981

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Multi ASIC GCU test cases for IDF and LinkCRC. #13210

Add Multi ASIC GCU test cases for IDF and LinkCRC. #13210

xincunli-sonic commented Jun 10, 2024 •

edited

Loading

mssonicbld commented Aug 9, 2024

mssonicbld commented Aug 10, 2024

mssonicbld commented Aug 10, 2024

mssonicbld commented Aug 19, 2024

xincunli-sonic commented Aug 19, 2024

mssonicbld commented Aug 19, 2024

azure-pipelines bot commented Aug 19, 2024

mssonicbld commented Aug 19, 2024

mssonicbld commented Oct 7, 2024

mssonicbld commented Oct 7, 2024

mssonicbld commented Oct 7, 2024

xincunli-sonic commented Nov 18, 2024

mssonicbld commented Nov 18, 2024

azure-pipelines bot commented Nov 18, 2024

xincunli-sonic commented Nov 23, 2024

mssonicbld commented Nov 23, 2024

azure-pipelines bot commented Nov 23, 2024

xincunli-sonic commented Nov 26, 2024

mssonicbld commented Nov 26, 2024

azure-pipelines bot commented Nov 26, 2024

judyjoseph Dec 3, 2024

judyjoseph Dec 3, 2024

tjchadaga Dec 3, 2024

mssonicbld commented Dec 12, 2024

azure-pipelines bot commented Dec 12, 2024

xincunli-sonic commented Dec 13, 2024

mssonicbld commented Dec 13, 2024

azure-pipelines bot commented Dec 13, 2024

mssonicbld commented Dec 13, 2024

azure-pipelines bot commented Dec 13, 2024

mssonicbld commented Dec 13, 2024

azure-pipelines bot commented Dec 13, 2024


		logger = logging.getLogger(__name__)

		IDF_ISOLATION = [

Add Multi ASIC GCU test cases for IDF and LinkCRC. #13210

Are you sure you want to change the base?

Add Multi ASIC GCU test cases for IDF and LinkCRC. #13210

Conversation

xincunli-sonic commented Jun 10, 2024 • edited Loading

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld commented Aug 9, 2024

mssonicbld commented Aug 10, 2024

mssonicbld commented Aug 10, 2024

mssonicbld commented Aug 19, 2024

xincunli-sonic commented Aug 19, 2024

mssonicbld commented Aug 19, 2024

azure-pipelines bot commented Aug 19, 2024

mssonicbld commented Aug 19, 2024

mssonicbld commented Oct 7, 2024

mssonicbld commented Oct 7, 2024

mssonicbld commented Oct 7, 2024

xincunli-sonic commented Nov 18, 2024

mssonicbld commented Nov 18, 2024

azure-pipelines bot commented Nov 18, 2024

xincunli-sonic commented Nov 23, 2024

mssonicbld commented Nov 23, 2024

azure-pipelines bot commented Nov 23, 2024

xincunli-sonic commented Nov 26, 2024

mssonicbld commented Nov 26, 2024

azure-pipelines bot commented Nov 26, 2024

judyjoseph Dec 3, 2024

Choose a reason for hiding this comment

judyjoseph Dec 3, 2024

Choose a reason for hiding this comment

tjchadaga Dec 3, 2024

Choose a reason for hiding this comment

mssonicbld commented Dec 12, 2024

azure-pipelines bot commented Dec 12, 2024

xincunli-sonic commented Dec 13, 2024

mssonicbld commented Dec 13, 2024

azure-pipelines bot commented Dec 13, 2024

mssonicbld commented Dec 13, 2024

azure-pipelines bot commented Dec 13, 2024

mssonicbld commented Dec 13, 2024

azure-pipelines bot commented Dec 13, 2024

xincunli-sonic commented Jun 10, 2024 •

edited

Loading