Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERR log ignore for ECMP/LAG hash not supported #15853

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

justin-wong-ce
Copy link
Contributor

Description of PR

Summary:
On Broadcom platforms, ECMP/LAG hash is not supported. Adding ERR log ignore as it is expected for this error log to print.

Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

On Broadcom platforms, ECMP/LAG hash is not supported. Adding ERR log ignore as it is expected for this error log to print.

How did you do it?

Added log regex to loganalyzer_common_ignore.txt

How did you verify/test it?

snmp/test_snmp_queue_counters.py no longer fails on loganalyzer error on Broadcom platform.

Any platform specific information?

Only applies to Broadcom platform.

Supported testbed topology if it's a new test case?

Documentation

On Broadcom platforms, ECMP/LAG hash is not supported. Adding ERR log
ignore as it is expected for this error log to print.
StormLiangMS
StormLiangMS previously approved these changes Dec 5, 2024
Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing ansible/roles/test/files/tools/loganalyzer/loganalyzer_common_ignore.txt

check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@justin-wong-ce
Copy link
Contributor Author

^Fixed merge conflict

Copy link
Contributor

@Gfrom2016 Gfrom2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justin-wong-ce
Copy link
Contributor Author

justin-wong-ce commented Dec 12, 2024

This log ignore causes one of the tests that are expected to fail in the CI check to pass, will be moving this logignore to manual extend in the individual test files with loganalyzer[dutIndex].ignore_regex.extend

Will involve:
snmp/test_snmp_queue_counters.py
drop_packets/drop_packets.py
bgp/test_bgp_bbr_default_state.py
bgp/test_bgp_bbr.py

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mssonicbld
Copy link
Collaborator

@justin-wong-ce PR conflicts with 202405 branch

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Dec 19, 2024
* Add ERR log ignore for ECMP/LAG hash not supported

On Broadcom platforms, ECMP/LAG hash is not supported. Adding ERR log
ignore as it is expected for this error log to print.

* Added platform checks to log ignore extension

* Remove extraneous file change
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Dec 19, 2024
* Add ERR log ignore for ECMP/LAG hash not supported

On Broadcom platforms, ECMP/LAG hash is not supported. Adding ERR log
ignore as it is expected for this error log to print.

* Added platform checks to log ignore extension

* Remove extraneous file change
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #16154

mssonicbld pushed a commit that referenced this pull request Dec 19, 2024
* Add ERR log ignore for ECMP/LAG hash not supported

On Broadcom platforms, ECMP/LAG hash is not supported. Adding ERR log
ignore as it is expected for this error log to print.

* Added platform checks to log ignore extension

* Remove extraneous file change
@justin-wong-ce
Copy link
Contributor Author

@justin-wong-ce PR conflicts with 202405 branch

202405 PR with conflict solved:
#16165

@justin-wong-ce justin-wong-ce deleted the brcm-hash-ignore branch January 24, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants