-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERR log ignore for ECMP/LAG hash not supported #15853
Add ERR log ignore for ECMP/LAG hash not supported #15853
Conversation
On Broadcom platforms, ECMP/LAG hash is not supported. Adding ERR log ignore as it is expected for this error log to print.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
^Fixed merge conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This log ignore causes one of the tests that are expected to fail in the CI check to pass, will be moving this logignore to manual extend in the individual test files with Will involve: |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@justin-wong-ce PR conflicts with 202405 branch |
* Add ERR log ignore for ECMP/LAG hash not supported On Broadcom platforms, ECMP/LAG hash is not supported. Adding ERR log ignore as it is expected for this error log to print. * Added platform checks to log ignore extension * Remove extraneous file change
* Add ERR log ignore for ECMP/LAG hash not supported On Broadcom platforms, ECMP/LAG hash is not supported. Adding ERR log ignore as it is expected for this error log to print. * Added platform checks to log ignore extension * Remove extraneous file change
Cherry-pick PR to 202411: #16154 |
* Add ERR log ignore for ECMP/LAG hash not supported On Broadcom platforms, ECMP/LAG hash is not supported. Adding ERR log ignore as it is expected for this error log to print. * Added platform checks to log ignore extension * Remove extraneous file change
202405 PR with conflict solved: |
Description of PR
Summary:
On Broadcom platforms, ECMP/LAG hash is not supported. Adding ERR log ignore as it is expected for this error log to print.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
On Broadcom platforms, ECMP/LAG hash is not supported. Adding ERR log ignore as it is expected for this error log to print.
How did you do it?
Added log regex to
loganalyzer_common_ignore.txt
How did you verify/test it?
snmp/test_snmp_queue_counters.py
no longer fails on loganalyzer error on Broadcom platform.Any platform specific information?
Only applies to Broadcom platform.
Supported testbed topology if it's a new test case?
Documentation