Add gnmi test for smartswitch #16053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
qiluo-msft
reviewed
Dec 13, 2024
tests/gnmi/helper.py
Outdated
| @@ -96,6 +96,7 @@ def apply_cert_config(duthost): | |||
| dut_command += "--config_table_name GNMI_CLIENT_CERT " | |||
| dut_command += "--client_auth cert " | |||
| dut_command += "--enable_crl=true " | |||
| dut_command += "--zmq_address=tcp://127.0.0.1:8100 " | |||
qiluo-msft
reviewed
Dec 13, 2024
tests/gnmi/test_gnmi_smartswitch.py
Outdated
| result = duthost.shell("show chassis module status") | ||
| for line in result['stdout_lines']: | ||
| module_status = line.split() | ||
| if "Online" in module_status: |
There was a problem hiding this comment.
Please initialize name_idx, oper_status_idx to something (like NULL) before the loop, and check valid values after the loop.
I understand the python code is working, but not robust, and easy to trigger bug, if there is global variable with the same names.
qiluo-msft
reviewed
Dec 13, 2024
tests/gnmi/test_gnmi_smartswitch.py
Outdated
| redis_port = data['INSTANCES']['redis']['port'] | ||
| file_name = "vnet.txt" | ||
| vni = "1000" | ||
| guid = "559c6ce8-26ab-4193-b946-ccc6e8f930b2" |
There was a problem hiding this comment.
Now I use uuid to generate guid.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Microsoft ADO: 28940620
Type of change
Back port request
Approach
What is the motivation for this PR?
Add gnmi end to end test for smartswitch
How did you do it?
Use GNMI to update the DASH_VNET_TABLE, and use redis cli to verify the DASH_VNET_TABLE in APPL_DB.
Only run test for smartswitch device.
How did you verify/test it?
Run gnmi end to end test
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation