fix for voq fabric related tests #16068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@mssonicbld I checked the test failed because of host unreachable in posttest not related to any changes I made please rerun |
|
@jfeng-arista, can you review this change |
rawal01
force-pushed
the
fix_enhance_voq_fabric
branch
from
10cbc86 to
9265ef8
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kenneth-arista
approved these changes
Dec 19, 2024
rawal01
force-pushed
the
fix_enhance_voq_fabric
branch
from
85bae55 to
a2bbe4d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@arlakshm can you help merge this PR ? |
|
The change looks good to me, also quickly tested on one of our systems and they are running ok. We can merge this up after Kenneth's comments get addressed. |
@jfeng-arista I already addressed all comments in latest commit please check |
arlakshm
approved these changes
Dec 20, 2024
yaqiangz
pushed a commit
to yaqiangz/sonic-mgmt
that referenced
this pull request
Dec 31, 2024
What is the motivation for this PR? Fixing issue 16067. How did you do it? Changed to not re-write originalIsolateStatus but instead write to isolateStatus. Also added try/catch block to both tests as today if the test fails it exits without restoring the state of the port. I also added check to tests/voq/test_fabric_reach.py::test_fabric_reach_supervisor to run against only if asic is present. Right not the tests get the max asics for the platform and assumes they are all present. How did you verify/test it? Ran against t2 Nokia chassis
|
@bingwang-ms please approve? thanks. |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 8, 2025
What is the motivation for this PR? Fixing issue 16067. How did you do it? Changed to not re-write originalIsolateStatus but instead write to isolateStatus. Also added try/catch block to both tests as today if the test fails it exits without restoring the state of the port. I also added check to tests/voq/test_fabric_reach.py::test_fabric_reach_supervisor to run against only if asic is present. Right not the tests get the max asics for the platform and assumes they are all present. How did you verify/test it? Ran against t2 Nokia chassis
|
Cherry-pick PR to 202405: #16393 |
6 tasks
great ! thank you |
mssonicbld
pushed a commit
that referenced
this pull request
Jan 30, 2025
What is the motivation for this PR? Fixing issue 16067. How did you do it? Changed to not re-write originalIsolateStatus but instead write to isolateStatus. Also added try/catch block to both tests as today if the test fails it exits without restoring the state of the port. I also added check to tests/voq/test_fabric_reach.py::test_fabric_reach_supervisor to run against only if asic is present. Right not the tests get the max asics for the platform and assumes they are all present. How did you verify/test it? Ran against t2 Nokia chassis
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # 16067
#16067
Type of change
Back port request
Approach
What is the motivation for this PR?
Fixing issue 16067.
How did you do it?
Changed to not re-write originalIsolateStatus but instead write to isolateStatus.
Also added try/catch block to both tests as today if the test fails it exits without restoring the state of the port.
I also added check to tests/voq/test_fabric_reach.py::test_fabric_reach_supervisor to run against only if asic is present. Right not the tests get the max asics for the platform and assumes they are all present.
How did you verify/test it?
Ran against t2 Nokia chassis
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation