-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T2: Change XOFF threshold for backplane links on long link line card #16550
Open
sreejithsreekumaran
wants to merge
3
commits into
sonic-net:master
Choose a base branch
from
sreejithsreekumaran:longlink_xoff_reduction
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
T2: Change XOFF threshold for backplane links on long link line card #16550
sreejithsreekumaran
wants to merge
3
commits into
sonic-net:master
from
sreejithsreekumaran:longlink_xoff_reduction
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng link card. Tests have been fixed to handle this specific change of XOFF threshold
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
alpeshspatel
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Updated qos yaml and uplifted few test cases for handing change in XOFF threshold of BP ports in long link LC
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
XOFF threshold in long link card for backplane port is being reduced due to the use of default voq mode
when HBM is enabled.
This voq mode uses the same voq for all source ports on the same slice destined to the same egress interface.
How did you do it?
Added a new entry in yaml file for the topology specific value for the test case and introduced conditional checks to read the new value.
How did you verify/test it?
Ran qos-sai tests on T2
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation