[202405][dhcp_relay] Add test case to verify dhcp6relay LLA waiting logic (#16494) #16567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogic (sonic-net#16494) What is the motivation for this PR? We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52 Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing How did you do it? Modify test_interface_binding: Remove LLA for Vlans Restart dhcp_relay container Verify whether sockets for LLA are not established Add LLA back Verify whether sockets for LLA are established How did you verify/test it? Run test_dhcpv6_relay.py
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bingwang-ms
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Manually cherry-pick #16554 since the dependency fucn
restart_dhcp_serviceis not included in 202405We add wait LLA logic in dhcp6relay with sonic-net/sonic-dhcp-relay#52 Current PR is to add test for it to verify dhcp6relay would work well when LLA is missing
How did you do it?
Modify test_interface_binding:
Remove LLA for Vlans
Restart dhcp_relay container
Verify whether sockets for LLA are not established Add LLA back
Verify whether sockets for LLA are established
How did you verify/test it?
Run test_dhcpv6_relay.py
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation