Add a check in reboot test to make sure PORT_INDEX_TABLE is populated before sending traffic.Enhance ValidateSutState to ValidateTestbedState by additionally checking Control Switch for MirrorTestbed.

[ksravani-hcl]

Keyword Check:
~/sk/sonic-buildimage/src/sonic-p4rt/sonic-pins$ ~/tools/keyword_checks.sh .
Keyword check Passed.

Build Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: Analyzed 710 targets (0 packages loaded, 0 targets configured).
INFO: Found 710 targets...
INFO: From Compiling tests/sflow/sflow_test.cc:
In file included from ./gutil/collections.h:29,
from tests/sflow/sflow_test.cc:51:
tests/sflow/sflow_test.cc: In function 'absl::lts_20230802::Status pins::{anonymous}::SetUpAclPunt(pdpi::P4RuntimeSession&, const pdpi::IrP4Info&, int)':
tests/sflow/sflow_test.cc:184:46: warning: 'absl::lts_20230802::StatusOrp4::v1::TableEntry pdpi::PartialPdTableEntryToPiTableEntry(const IrP4Info&, const google::protobuf::Message&, const TranslationOptions&)' is deprecated: Use PdTableEntryToPiEntity instead [-Wdeprecated-declarations]
184 | pdpi::PartialPdTableEntryToPiTableEntry(
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
185 | ir_p4info,
| ~~~~~~~~~~
186 | gutil::ParseProtoOrDiesai::TableEntry(absl::Substitute(
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
187 | R"pb(
| ~~~~~
188 | acl_ingress_table_entry {
| ~~~~~~~~~~~~~~~~~~~~~~~~~
189 | match {
| ~~~~~~~
190 | dst_mac { value: "$0" mask: "ff:ff:ff:ff:ff:ff" }
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
191 | is_ipv4 { value: "0x1" }
| ~~~~~~~~~~~~~~~~~~~~~~~~
192 | dst_ip { value: "$1" mask: "255.255.255.255" }
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
193 | }
| ~
194 | action { acl_trap { qos_queue: "0x7" } }
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
195 | priority: 1
| ~~~~~~~~~~~
196 | }
| ~
197 | )pb",
| ~~~~~
198 | kDstMac.ToString(), GetDstIpv4AddrByPortId(port_id)))));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./gutil/status.h:286:43: note: in definition of macro '__ASSIGN_OR_RETURN'
286 | auto __ASSIGN_OR_RETURN_VAL(LINE) = expr;
| ^~~~
tests/sflow/sflow_test.cc:182:3: note: in expansion of macro 'ASSIGN_OR_RETURN'
182 | ASSIGN_OR_RETURN(
| ^~~~~~~~~~~~~~~~
In file included from tests/sflow/sflow_test.cc:69:
./p4_pdpi/pd.h:142:36: note: declared here
142 | absl::StatusOrp4::v1::TableEntry PartialPdTableEntryToPiTableEntry(
tests/qos/cpu_qos_test.cc: At global scope:
tests/qos/cpu_qos_test.cc:845:14: warning: 'absl::lts_20230802::Status pins_test::{anonymous}::IncrementTransmittedPackets(pins_test::openconfig::Queues_Queue::State&, int)' defined but not used [-Wunused-function]
845 | absl::Status IncrementTransmittedPackets(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
tests/qos/cpu_qos_test.cc:838:14: warning: 'absl::lts_20230802::Status pins_test::{anonymous}::InstallAclEntriesToFilterOutUnsolicitedPackets(pdpi::P4RuntimeSession&)' defined but not used [-Wunused-function]
838 | absl::Status InstallAclEntriesToFilterOutUnsolicitedPackets(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tests/qos/cpu_qos_test.cc:834:6: warning: 'bool pins_test::{anonymous}::IsValidCpuQueue(absl::lts_20230802::string_view)' defined but not used [-Wunused-function]
834 | bool IsValidCpuQueue(absl::string_view queue_name) {
| ^~~~~~~~~~~~~~~
tests/qos/cpu_qos_test.cc:827:6: warning: 'void pins_test::{anonymous}::EraseQueuesFromSnapshot(const absl::lts_20230802::flat_hash_set<std::__cxx11::basic_string >&, pins_test::openconfig::QueuesByName&)' defined but not used [-Wunused-function]
827 | void EraseQueuesFromSnapshot(const absl::flat_hash_setstd::string &queues,
| ^~~~~~~~~~~~~~~~~~~~~~~
tests/qos/cpu_qos_test.cc:813:34: warning: 'absl::lts_20230802::flat_hash_set<std::__cxx11::basic_string > pins_test::{anonymous}::QueuesWithTransmittedPacketDifferences(const pins_test::openconfig::QueuesByName&, const pins_test::openconfig::QueuesByName&)' defined but not used [-Wunused-function]
813 | absl::flat_hash_setstd::string QueuesWithTransmittedPacketDifferences(
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tests/qos/cpu_qos_test.cc:508:36: warning: 'absl::lts_20230802::StatusOrp4::v1::TableEntry pins_test::{anonymous}::MakeRouterInterface(absl::lts_20230802::string_view, absl::lts_20230802::string_view, const netaddr::MacAddress&, const pdpi::IrP4Info&)' defined but not used [-Wunused-function]
508 | absl::StatusOrp4::v1::TableEntry MakeRouterInterface(
| ^~~~~~~~~~~~~~~~~~~
tests/qos/cpu_qos_test.cc:449:35: warning: 'absl::lts_20230802::StatusOrpacketlib::Packet pins_test::{anonymous}::MakeIpv6PacketWithDscp(const netaddr::MacAddress&, const netaddr::Ipv6Address&, int)' defined but not used [-Wunused-function]
449 | absl::StatusOrpacketlib::Packet MakeIpv6PacketWithDscp(
| ^~~~~~~~~~~~~~~~~~~~~~
tests/qos/cpu_qos_test.cc:416:35: warning: 'absl::lts_20230802::StatusOrpacketlib::Packet pins_test::{anonymous}::MakeIpv4PacketWithDscp(const netaddr::MacAddress&, const netaddr::Ipv4Address&, int)' defined but not used [-Wunused-function]
416 | absl::StatusOrpacketlib::Packet MakeIpv4PacketWithDscp(
| ^~~~~~~~~~~~~~~~~~~~~~
tests/qos/cpu_qos_test.cc:184:14: warning: 'absl::lts_20230802::Status pins_test::{anonymous}::SetUpPuntToCPU(const netaddr::MacAddress&, const netaddr::Ipv4Address&, absl::lts_20230802::string_view, const p4::config::v1::P4Info&, pdpi::P4RuntimeSession&)' defined but not used [-Wunused-function]
184 | absl::Status SetUpPuntToCPU(const netaddr::MacAddress &dmac,
| ^~~~~~~~~~~~~~
INFO: Elapsed time: 33.150s, Critical Path: 32.31s
INFO: 12 processes: 2 internal, 10 linux-sandbox.
INFO: Build completed successfully, 12 total actions

Test Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
INFO: Analyzed 710 targets (0 packages loaded, 0 targets configured).
INFO: Found 488 targets and 222 test targets...
INFO: Elapsed time: 240.567s, Critical Path: 114.41s
INFO: 279 processes: 336 linux-sandbox, 18 local.
INFO: Build completed successfully, 279 total actions
//dvaas:port_id_map_test PASSED in 0.8s
//dvaas:test_run_validation_golden_test PASSED in 0.0s
//dvaas:test_run_validation_test PASSED in 0.6s
//dvaas:test_run_validation_test_runner PASSED in 0.0s
//dvaas:test_vector_stats_diff_test PASSED in 0.1s
//dvaas:test_vector_stats_test PASSED in 0.0s
//dvaas:test_vector_test PASSED in 0.6s
//dvaas:user_provided_packet_test_vector_diff_test PASSED in 0.1s
//dvaas:user_provided_packet_test_vector_test PASSED in 0.1s
//gutil:collections_test PASSED in 0.6s
//gutil:io_test PASSED in 0.5s
//gutil:proto_matchers_test PASSED in 0.6s
//gutil:proto_ordering_test PASSED in 0.5s
//gutil:proto_test PASSED in 0.5s
//gutil:status_matchers_test PASSED in 0.5s
//gutil:test_artifact_writer_test PASSED in 0.6s
//gutil:testing_test PASSED in 0.6s
//gutil:timer_test PASSED in 5.0s
//gutil:version_test PASSED in 0.9s
//lib:basic_switch_test PASSED in 0.8s
//lib:ixia_helper_test PASSED in 1.1s
//lib/basic_traffic:basic_p4rt_util_test PASSED in 0.9s
//lib/basic_traffic:basic_traffic_test PASSED in 15.1s
//p4rt_app/tests:state_verification_test PASSED in 2.7s
//p4rt_app/tests:vrf_table_test PASSED in 2.4s
//p4rt_app/tests/lib:app_db_entry_builder_test PASSED in 0.1s
//p4rt_app/utils:event_data_tracker_test PASSED in 0.0s
//p4rt_app/utils:table_utility_test PASSED in 0.7s
//sai_p4/instantiations/google:clos_stage_test PASSED in 0.5s
//sai_p4/instantiations/google:fabric_border_router_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:middleblock_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_build_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_cc_test PASSED in 0.6s
//sai_p4/instantiations/google:sai_p4info_fetcher_test PASSED in 0.7s
//sai_p4/instantiations/google:sai_p4info_test PASSED in 1.1s
//sai_p4/instantiations/google:sai_pd_proto_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_pd_util_test PASSED in 0.5s
//sai_p4/instantiations/google:tor_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:union_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google:wbb_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google/test_tools:table_entry_generator_helper_test PASSED in 1.4s
//sai_p4/instantiations/google/test_tools:test_entries_test PASSED in 0.9s
//sai_p4/instantiations/google/tests:p4_fuzzer_integration_test PASSED in 3.4s
//sai_p4/tools:p4info_tools_test PASSED in 0.6s
//sai_p4/tools:packetio_tools_test PASSED in 0.8s
//tests:thinkit_gnmi_interface_util_tests PASSED in 1.2s
//tests/forwarding:hash_statistics_util_test PASSED in 0.9s
//tests/lib:p4info_helper_test PASSED in 0.8s
//tests/lib:p4rt_fixed_table_programming_helper_test PASSED in 0.9s
//tests/lib:switch_test_setup_helpers_golden_test PASSED in 0.1s
//tests/lib:switch_test_setup_helpers_golden_test_runner PASSED in 0.1s
//tests/qos:gnmi_parsers_test PASSED in 0.1s
//tests/qos:gnmi_parsers_test_runner PASSED in 0.1s
//tests/sflow:sflow_util_test PASSED in 6.8s
//thinkit:bazel_test_environment_test PASSED in 0.5s
//thinkit:generic_testbed_test PASSED in 0.9s
//thinkit:mock_control_device_test PASSED in 0.6s
//thinkit:mock_generic_testbed_test PASSED in 0.7s
//thinkit:mock_mirror_testbed_test PASSED in 0.7s
//thinkit:mock_ssh_client_test PASSED in 0.0s
//thinkit:mock_switch_test PASSED in 0.7s
//thinkit:mock_test_environment_test PASSED in 0.1s
//thinkit:switch_test PASSED in 0.7s
//tests/lib:packet_generator_test PASSED in 63.1s
Stats over 4 runs: max = 63.1s, min = 59.8s, avg = 61.6s, dev = 1.2s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test PASSED in 0.8s
Stats over 5 runs: max = 0.8s, min = 0.7s, avg = 0.7s, dev = 0.1s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test PASSED in 44.1s
Stats over 50 runs: max = 44.1s, min = 0.8s, avg = 4.6s, dev = 11.6s

Executed 222 out of 222 tests: 222 tests pass.
INFO: Build completed successfully, 279 total actions

[mssonicbld]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[ksravani-hcl]

Co-authored-by: Srikishen Pondicherry Shanmugam [email protected]