[P4_Symbolic] Add timer class, taken from packet synthesizer. #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
No pipelines are associated with this pull request. |
ksravani-hcl
force-pushed
the
symbolic_10
branch
from
52116b9 to
3fc6ef5
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
ksravani-hcl
force-pushed
the
symbolic_10
branch
from
3fc6ef5 to
ff051b2
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
ksravani-hcl
force-pushed
the
symbolic_10
branch
from
ff051b2 to
45f96e2
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
ksravani-hcl
force-pushed
the
symbolic_10
branch
from
45f96e2 to
029b0c2
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
ksravani-hcl
force-pushed
the
symbolic_10
branch
from
029b0c2 to
4fd67df
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
ksravani-hcl
force-pushed
the
symbolic_10
branch
from
4fd67df to
cebbed9
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
|
Co-authored-by: Steffen Smolka [email protected] |
ksravani-hcl
force-pushed
the
symbolic_10
branch
from
cebbed9 to
ac365e0
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
ksravani-hcl
force-pushed
the
symbolic_10
branch
from
ac365e0 to
a3c8ab3
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
jaanah-hcl
approved these changes
Feb 7, 2025
ksravani-hcl
force-pushed
the
symbolic_10
branch
from
a3c8ab3 to
5446198
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
ksravani-hcl
force-pushed
the
symbolic_10
branch
from
5446198 to
2712d2e
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
ksravani-hcl
force-pushed
the
symbolic_10
branch
from
2712d2e to
12ba1b9
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
jaanah-hcl
approved these changes
Feb 14, 2025
kishanps
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyword Check:
~/sonic-buildimage/src/sonic-p4rt/sonic-pins$ ~/tools/keyword_checks.sh .
Keyword check Passed.
Build Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: Analyzed 697 targets (1 packages loaded, 4 targets configured).
INFO: Found 697 targets...
INFO: From Compiling p4_symbolic/tests/sai_p4_integration_test.cc:
In file included from ./p4_symbolic/z3_util.h:26,
from ./p4_symbolic/symbolic/symbolic.h:36,
from ./p4_symbolic/sai/sai.h:25,
from p4_symbolic/tests/sai_p4_integration_test.cc:38:
./p4_pdpi/string_encodings/bit_string.h: In member function 'void pdpi::BitString::AppendBytes(absl::lts_20230802::string_view)':
./p4_pdpi/string_encodings/bit_string.h:55:23: warning: comparison of integer expressions of different signedness: 'int' and 'std::basic_string_view::size_type' {aka 'long unsigned int'} [-Wsign-compare]
55 | for (int i = 0; i < bytes.size(); i++) {
| ~~^~~~~~~~~~~~~~
p4_symbolic/tests/sai_p4_integration_test.cc: In member function 'virtual void p4_symbolic::{anonymous}::P4SymbolicIntegrationTest_CanGenerateTestPacketsForSimpleSaiP4EntriesWithTunneling_Test::TestBody()':
p4_symbolic/tests/sai_p4_integration_test.cc:382:9: warning: unused variable 'egress' [-Wunused-variable]
382 | auto& egress = solution->egress_headers;
| ^~~~~~
In file included from ./p4_symbolic/z3_util.h:26,
from ./p4_symbolic/symbolic/symbolic.h:36,
from ./p4_symbolic/sai/sai.h:25,
from p4_symbolic/tests/sai_p4_integration_test.cc:38:
./p4_pdpi/string_encodings/bit_string.h: In instantiation of 'void pdpi::BitString::AppendBits(const std::bitset<_Nb>&) [with long unsigned int num_bits = 8]':
./p4_pdpi/string_encodings/bit_string.h:41:50: required from here
./p4_pdpi/string_encodings/bit_string.h:49:23: warning: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Wsign-compare]
49 | for (int i = 0; i < num_bits; i++) {
| ^~~~~~~~~~~~~~~~~~~~
INFO: From Compiling p4_symbolic/tests/symbolic_table_entries_test.cc:
In file included from ./p4_symbolic/z3_util.h:26,
from ./p4_symbolic/symbolic/symbolic.h:36,
from ./p4_symbolic/sai/sai.h:25,
from p4_symbolic/tests/symbolic_table_entries_test.cc:46:
./p4_pdpi/string_encodings/bit_string.h: In member function 'void pdpi::BitString::AppendBytes(absl::lts_20230802::string_view)':
./p4_pdpi/string_encodings/bit_string.h:55:23: warning: comparison of integer expressions of different signedness: 'int' and 'std::basic_string_view::size_type' {aka 'long unsigned int'} [-Wsign-compare]
55 | for (int i = 0; i < bytes.size(); i++) {
| ~~^~~~~~~~~~~~~~
./p4_pdpi/string_encodings/bit_string.h: In instantiation of 'void pdpi::BitString::AppendBits(const std::bitset<_Nb>&) [with long unsigned int num_bits = 8]':
./p4_pdpi/string_encodings/bit_string.h:41:50: required from here
./p4_pdpi/string_encodings/bit_string.h:49:23: warning: comparison of integer expressions of different signedness: 'int' and 'long unsigned int' [-Wsign-compare]
49 | for (int i = 0; i < num_bits; i++) {
| ~~^~~~~~~~~~
INFO: Elapsed time: 12.724s, Critical Path: 11.99s
INFO: 9 processes: 5 internal, 4 linux-sandbox.
INFO: Build completed successfully, 9 total actions
Test Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
INFO: Analyzed 697 targets (0 packages loaded, 2 targets configured).
INFO: Found 478 targets and 219 test targets...
INFO: Elapsed time: 182.023s, Critical Path: 111.86s
INFO: 273 processes: 328 linux-sandbox, 18 local.
INFO: Build completed successfully, 273 total actions
//dvaas:port_id_map_test PASSED in 0.8s
//dvaas:test_run_validation_golden_test PASSED in 0.1s
//dvaas:test_run_validation_test PASSED in 0.6s
//dvaas:test_run_validation_test_runner PASSED in 0.0s
//dvaas:test_vector_stats_diff_test PASSED in 0.0s
//dvaas:test_vector_stats_test PASSED in 0.0s
//dvaas:test_vector_test PASSED in 0.6s
//dvaas:user_provided_packet_test_vector_diff_test PASSED in 0.1s
//dvaas:user_provided_packet_test_vector_test PASSED in 1.2s
//gutil:collections_test PASSED in 0.5s
//gutil:io_test PASSED in 0.5s
//gutil:proto_matchers_test PASSED in 0.7s
//gutil:proto_ordering_test PASSED in 0.6s
//gutil:proto_test PASSED in 0.5s
//gutil:status_matchers_test PASSED in 0.5s
//gutil:test_artifact_writer_test PASSED in 0.7s
//gutil:testing_test PASSED in 0.5s
//gutil:timer_test PASSED in 5.0s
//gutil:version_test PASSED in 1.1s
//p4rt_app/tests:resource_limits_test PASSED in 3.3s
//p4rt_app/tests:response_path_test PASSED in 6.8s
//p4rt_app/tests:role_test PASSED in 1.6s
//p4rt_app/tests:state_verification_test PASSED in 3.4s
//p4rt_app/tests:vrf_table_test PASSED in 2.7s
//p4rt_app/tests/lib:app_db_entry_builder_test PASSED in 0.0s
//p4rt_app/utils:event_data_tracker_test PASSED in 0.0s
//p4rt_app/utils:table_utility_test PASSED in 0.7s
//sai_p4/instantiations/google:clos_stage_test PASSED in 0.6s
//sai_p4/instantiations/google:fabric_border_router_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:middleblock_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_build_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_cc_test PASSED in 0.6s
//sai_p4/instantiations/google:sai_p4info_fetcher_test PASSED in 0.7s
//sai_p4/instantiations/google:sai_p4info_test PASSED in 1.2s
//sai_p4/instantiations/google:sai_pd_proto_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_pd_util_test PASSED in 0.6s
//sai_p4/instantiations/google:tor_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:union_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google:wbb_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google/test_tools:table_entry_generator_helper_test PASSED in 1.5s
//sai_p4/instantiations/google/test_tools:test_entries_test PASSED in 0.9s
//sai_p4/instantiations/google/tests:p4_fuzzer_integration_test PASSED in 3.6s
//sai_p4/tools:p4info_tools_test PASSED in 0.6s
//sai_p4/tools:packetio_tools_test PASSED in 0.7s
//tests:thinkit_gnmi_interface_util_tests PASSED in 1.2s
//tests/lib:p4info_helper_test PASSED in 0.8s
//tests/lib:p4rt_fixed_table_programming_helper_test PASSED in 0.8s
//tests/lib:packet_generator_test PASSED in 27.2s
//tests/lib:switch_test_setup_helpers_golden_test PASSED in 0.1s
//tests/lib:switch_test_setup_helpers_golden_test_runner PASSED in 0.1s
//tests/qos:gnmi_parsers_test PASSED in 0.0s
//tests/qos:gnmi_parsers_test_runner PASSED in 0.0s
//tests/sflow:sflow_util_test PASSED in 6.9s
//thinkit:bazel_test_environment_test PASSED in 0.6s
//thinkit:generic_testbed_test PASSED in 0.9s
//thinkit:mock_control_device_test PASSED in 0.5s
//thinkit:mock_generic_testbed_test PASSED in 0.9s
//thinkit:mock_mirror_testbed_test PASSED in 0.7s
//thinkit:mock_ssh_client_test PASSED in 0.1s
//thinkit:mock_switch_test PASSED in 0.7s
//thinkit:mock_test_environment_test PASSED in 0.1s
//thinkit:switch_test PASSED in 0.7s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test PASSED in 0.9s
Stats over 5 runs: max = 0.9s, min = 0.7s, avg = 0.7s, dev = 0.1s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test PASSED in 44.0s
Stats over 50 runs: max = 44.0s, min = 0.8s, avg = 3.5s, dev = 10.2s
Executed 219 out of 219 tests: 219 tests pass.
INFO: Build completed successfully, 273 total actions