Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added change not to create ECMP Group in SAI and program the route if none of ECMP members are active/link-up #3394

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Nov 26, 2024

What I did:
Added change not to create ECMP Group in SAI and program the route if none of the ECMP members are active/link-up.
Also do not program the Temp Route if Neigh is not active (Link Down)

Why I did:
In scale setup of T2 it's possible all links can go down simultaneously which case we can get Route messages with all nexthops being in down state. In such case we might create empty Nexthop Group in SAI for the given route which causes not needed SAI call for Nexthop Group creation and also create traffic blackhole for the route where that route can still forward traffic via default route if eligible/applicable.

Also in this case no point to add Temp Route if neighbor is link down.

How I verify:

  1. Compile time test was failing because of this chnage so added oper_status as UP in the mock tests
  2. Added UT for this scenario.
  3. Ixia Convergence tests

all the members of ECMP groups are inactive.

Signed-off-by: Abhishek Dosi <[email protected]>
@abdosi abdosi requested a review from prsunny as a code owner November 26, 2024 02:49
@abdosi abdosi requested review from prsunny and removed request for prsunny November 26, 2024 02:50
@abdosi abdosi changed the title Added change not to create ECMP Group in SAI and program the route if not of ECMP members are active/link-up Added change not to create ECMP Group in SAI and program the route if none of ECMP members are active/link-up Nov 26, 2024
@rlhui
Copy link
Contributor

rlhui commented Nov 27, 2024

@prsunny reminder to review, thanks.

@prsunny
Copy link
Collaborator

prsunny commented Dec 3, 2024

@abdosi , i think the test failures are specific to this PR as I see it passing for all others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants