Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI for bmp configdb entity Enable/Disable. #3260

Closed
wants to merge 1 commit into from

Conversation

FengPan-Frank
Copy link
Contributor

@FengPan-Frank FengPan-Frank commented Apr 5, 2024

What I did

Add CLI for bmp configdb entity Enable/Disable.

How I did it

Add python related code for Get/Set configdb entity, which is on sonic-net/sonic-buildimage#18530

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

if not bmp_table:
bmp_table = {'table': {'bgp_neighbor_table': 'true'}}
else:
bmp_table['table']['bgp_neighbor_table'] = 'true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table

If 'table' not in bmp_table, will it throw exception?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. and moved into #3286 since this PR was not created on fork branch.

#
@bmp.group()
@click.pass_context
def enable(ctx):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable

Please add unit test and ensure each changed line covered.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. and moved into #3286 since this PR was not created on fork branch.

@FengPan-Frank FengPan-Frank changed the title Add CLI for bmp configdb entity Get/Set. Add CLI for bmp configdb entity Enable/Disable. Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants