Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow export of all conjugations/declension into a JSON-like file words_forms.txt #159

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

bt2901
Copy link
Contributor

@bt2901 bt2901 commented Oct 18, 2021

No description provided.

@@ -82,6 +82,14 @@ export function declensionAdjective(adj: string, postfix: string): any {

function establish_root(adj) {
let result = '';
if (adj.indexOf(' ') !== -1) {
console.log(adj);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No console.logs in prod code, please :)

@bt2901
Copy link
Contributor Author

bt2901 commented Oct 18, 2021

This PR changes the declension of composite adjectives (such as podpirany od, osnovany na, dobro informovany, and vyše veliky). In some cases the old behaviour was obviously incorrect:

   ● adjective › adjective osnovany na
"positive": Array [
-       "y",
-       "o",
+       "osnovany",
+       "osnovano",
],
"superlative": Array [
-       "najši",
-       "najje",
+       "najosnovanějši",
+       "najosnovaněje",
],
},
...
   ● adjective › adjective seksuaľno privlěkateljny
"superlative": Array [
-       "najseksuaľno privlěkateljnějši",
-       "najseksuaľno privlěkateljněje",
+       "najprivlěkateljnějši",
+       "najprivlěkateljněje",
]

In some cases, both old and new behaviours are weird but understandable:

   ● adjective › adjective dobro informovany
"comparative": Array [
-       "dobro informovanějši",
-       "dobro informovaněje",
+       "informovanějši",
+       "informovaněje",
],
"superlative": Array [
-       "najdobro informovanějši",
-       "najdobro informovaněje",
+       "najinformovanějši",
+       "najinformovaněje",
],
...
   ● adjective › adjective krajno opasny
"superlative": Array [
-       "najkrajno opasnějši",
-       "najkrajno opasněje",
+       "najopasnějši",
+       "najopasněje",

And in some cases I am sincerely unsure whether my fix improves things:

   ● adjective › adjective tako rěčeny
"superlative": Array [
-       "najtako rěčenějši",
-       "najtako rěčeněje",
+       "najrěčenějši",
+       "najrěčeněje",

   ● adjective › adjective vyše veliky
"comparative": Array [
-       "vyše veličějši",
-       "vyše veličeje",
+       "vęčši",
+       "vęče",
"superlative": Array [
-       "najvyše veličějši",
-       "najvyše veličeje",
+       "najvęčši",
+       "najvęče",

Do we need to think about this? For example, I would suggest something like najvyše dobro informovany, vyše dobro informovany, lěpje informovano and lěpje informovany as comparative and superlative forms for some of these adjectives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants