-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow export of all conjugations/declension into a JSON-like file words_forms.txt #159
base: master
Are you sure you want to change the base?
Conversation
src/legacy/declensionAdjective.ts
Outdated
@@ -82,6 +82,14 @@ export function declensionAdjective(adj: string, postfix: string): any { | |||
|
|||
function establish_root(adj) { | |||
let result = ''; | |||
if (adj.indexOf(' ') !== -1) { | |||
console.log(adj); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No console.log
s in prod code, please :)
This PR changes the declension of composite adjectives (such as
In some cases, both old and new behaviours are weird but understandable:
And in some cases I am sincerely unsure whether my fix improves things:
Do we need to think about this? For example, I would suggest something like |
No description provided.