Misc: Warn that WINDECO option does nothing on Wayland #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonic2kk
force-pushed
the
windeco-wayland-warning
branch
from
d66879d to
eb4f38b
Compare
|
Apparently, toggling window decorations requires a restart, because we only set it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yad allows you to specify a
--decoratedor--undecoratedoption for dialogs, which we control withWINDECO. However this flag has no effect on Wayland. This may be because Mutter, GNOME's Wayland compositor (Yad is a GTK3 tool), does not implement thexdg-decorationprotocol at time of writing. KDE does, and window decorations can be toggled with a KWin rule and with a keyboard shortcut to "Toggle Window Titlebar and Frame" (it also disables shadows, like it does on X11). This seems to be a rabbit hole debate around server-side vs client-side decorations!This PR adds a warning for this and updates the langfile strings to note this, as I don't see this being resolved anytime soon.