Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented MO2 silent mode #1097

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

zerodogg
Copy link
Contributor

This successfully launches Fallout: New Vegas with mo2 in silent mode for me

@sonic2kk
Copy link
Owner

Holy heck!! Thank you so much for this!

I am shocked to be honest. I didn't think Silent mode would ever get implemented (I didn't even know if it was still possible with MO2).

I'm going to test later today 😄

@sonic2kk
Copy link
Owner

Worked for me with New Vegas (fresh install, one mod) and Oblivion (existing install, many mods). We need to expose an option to allow this on the UI, under the MO2 mode dropdown, but that can be done at a later time :-)

I will merge this soon. Thanks a ton for this!!

@sonic2kk
Copy link
Owner

Still new to pushing to other people's PRs, tried to bump the version to merge this. I think it's good now, although due to the rebase I'm now a co-author of the commit (sorry).

You'll still get full credit in the changelog, and also wanted to say in this comment that this PR is fully your own work, it's just because of git-weirdness that I am a "co"-author; all this work is yours, not mine :-)


This is ready to merge. Thank you a lot for your contribution!

@sonic2kk sonic2kk merged commit 18fd5f3 into sonic2kk:master Apr 29, 2024
1 check passed
@sonic2kk
Copy link
Owner

On the squash-merge commit you're listed as the sole author (18fd5f3), awesome!! Nothing to worry about then it seems :-)

Credit has also been given for your work on the changelog! I will update the wiki to note that Silent Mode is now implemented, and push a change to add silent as a ModOrganizer 2 mode to the UI.

@zerodogg
Copy link
Contributor Author

Cheers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants