Add BinEinsum to suite-unit #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisChourakiSonos
force-pushed
the
task/improve-metal-test
branch
from
3561f3e to
d1af7c7
Compare
kali
requested changes
Jan 30, 2025
core/src/ops/einsum/as_matmul.rs
Outdated
| } | ||
| AxesOrPatch::NotAMatMul(axes) => { | ||
| bail!("{} is not a matmul because of axis {}", op.axes, axes.iter().map(|a| a.repr).join(", ") ) | ||
| } |
test-rt/suite-unit/src/bin_einsum.rs
Outdated
| }) | ||
| }) | ||
| .prop_map(|(supp_m_axes, supp_n_axes, iter_axes, trivial_m_axes, trivial_n_axes)| { | ||
| dbg!(supp_m_axes, supp_n_axes, iter_axes, trivial_m_axes, trivial_n_axes); |
There was a problem hiding this comment.
Nope, I forgot to remove it
test-rt/suite-unit/src/bin_einsum.rs
Outdated
| let b_axes: Vec<char> = | ||
| (n_axes.clone() + "g" + &trivial_n_axes + &iter_axes + "k").chars().collect(); | ||
| let c_axes: Vec<char> = | ||
| (m_axes + &n_axes + "ag" + &trivial_m_axes + &trivial_n_axes + &iter_axes) |
There was a problem hiding this comment.
for our sanity, is it possible to re-arrange letters affectation so that "a" becomes "m" and "g" besomes "n" ? :)
test-rt/suite-unit/src/bin_einsum.rs
Outdated
| //if let Some(c) = &self.unicast_add_constant { | ||
| // let c = model.add_const("c", c.clone())?; | ||
| // output = model.wire_node("add", tract_core::ops::math::add(), &[output[0], c])?; | ||
| //} |
There was a problem hiding this comment.
should we try to put these back (they play a role in classic Q8 ops only)
kali
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.