Changed NULL
used as a null pointer to nullptr
.
#11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all codes use
nullptr
, but these two codes don't.If you don't have any special reasons to use
NULL
, I think it should be unified.By the way, do you have any CIs to test codes for multiple platforms? I don't have WindowsPC to build and test. I confirmed all tests(excepted for the tests reported #1) have passed only on MacOSX.