Skip to content

Commit

Permalink
Fixed qty input of fractions as well as allowing pasting of values ou…
Browse files Browse the repository at this point in the history
…tside valid range.
  • Loading branch information
amenconi committed Feb 16, 2024
1 parent 5c136c9 commit 433eb7e
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 4 deletions.
1 change: 1 addition & 0 deletions src/app/pages/nft/pages/nft/nft.page.html
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ <h1 class="mt-2 mb-1">{{ getTitle(data.nft$ | async) }}</h1>
[(ngModel)]="nftQtySelected"
(ngModelChange)="updateQuantity()"
#quantityInput="ngModel"
(paste)="forceValidRange($event)"
min="1"
max="{{ getAvailableNftQuantity(collection, nft) }}"
/>
Expand Down
37 changes: 33 additions & 4 deletions src/app/pages/nft/pages/nft/nft.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -419,16 +419,45 @@ export class NFTPage implements OnInit, OnDestroy {
this.data.collection$.value,
this.data.nft$.value,
);
const parsedQuantity = Number(this.nftQtySelected);
if (isNaN(parsedQuantity) || parsedQuantity < 1) {
let parsedQuantity = Math.round(Number(this.nftQtySelected));

Check failure on line 422 in src/app/pages/nft/pages/nft/nft.page.ts

View workflow job for this annotation

GitHub Actions / front_end_es_lint

'parsedQuantity' is never reassigned. Use 'const' instead

if (isNaN(parsedQuantity) || parsedQuantity <= 0) {
this.nftQtySelected = 1;
this.resetInput();
} else if (parsedQuantity > maxQuantity) {
this.nftQtySelected = maxQuantity;
this.resetInput();
} else {
this.nftQtySelected = parsedQuantity;
}

if (parsedQuantity === this.nftQtySelected) {
return;
} else {
this.resetInput();
}
}

public forceValidRange(event: ClipboardEvent): void {
event.preventDefault();

if (event.clipboardData) {
const pastedData = event.clipboardData.getData('text/plain');
let parsedQuantity = Math.round(Number(pastedData));

Check failure on line 444 in src/app/pages/nft/pages/nft/nft.page.ts

View workflow job for this annotation

GitHub Actions / front_end_es_lint

'parsedQuantity' is never reassigned. Use 'const' instead

const maxQuantity = this.getAvailableNftQuantity(
this.data.collection$.value,
this.data.nft$.value,
);

if (isNaN(parsedQuantity) || parsedQuantity <= 0) {
this.nftQtySelected = 1;
} else if (parsedQuantity > maxQuantity) {
this.nftQtySelected = maxQuantity;
} else {
this.nftQtySelected = parsedQuantity;
}

this.resetInput();
}
}

private resetInput() {
Expand Down

0 comments on commit 433eb7e

Please sign in to comment.