-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented single nft bulk buy #127
Implemented single nft bulk buy #127
Conversation
Deploying with
|
Latest commit: |
619b91d
|
Status: | ✅ Deploy successful! |
Preview URL: | https://5ddb3d56.app-cqo.pages.dev |
Branch Preview URL: | https://amenconi-bulk-buy-single-nft.app-cqo.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me! Great effort. I think it's important we get some community members to test this. I'll reach out to the task force as well.
Right now cloud flare runs build for every PR (as might have noticed) and it generates random URL. This is against the TEST API atm. I'm unable to generate two Cloudflare instances for PR (one prod and one test). I think when you ask general audience to test this it'll be hard for them to test against the TEST database as there isn't much data. It'll be easier for them to test on the production data. They can always create dummy user.
I've changed the Cloudflare to connect these preview branches to PROD database. Let me know if you think I should revert it.
Test URL for this branch is available here: https://amenconi-bulk-buy-single-nft.app-cqo.pages.dev/
@SoonaverseTF - I'll wait for you to approve the testing and give green light for release! Please comment here once done. @SoonaverseTF - please also determine the TOKEN reward so we can update CONTRIBUTORS.md and execute SOON distribution |
Pushed commit with fixes so that all typed and pasted values get rounded to whole integers that are closest within the valid range. Looks like the Cloudflare Pages build failed though, looks like reviewing logs for that require log in access for Cloudflare, if I need to make any changes to fix this please let me know. Thanks! |
Hi Adam. I think so. Once done I can add a bit of code so that choosing a quantity over more than 1 for an NFT on the NFT page will allow you to buy that number in NFT checkout or alternately add that quantity of the NFT to the cart. Thanks. |
@amenconi I run some tests, here is my feedback:
|
sounds great, I've rebased to "amenconi-shopping-cart" but there seems to be conflict. Once you resolve them I'll merge. |
@amenconi / @amenconi - you can continue conversation about this one on the #128 |
On the NFT page, when applicable, an input will allow a quantity to be typed in or incremented/decremented using up/down arrows. When "Buy now" button is pressed the input quantity of NFTs is passed to the checkout drawer.
If a quantity of more than 1 is passed then it will display a warning informing the user that multiple NFTs have been selected to be purchased.
NFT purchase flow for user will be same as for single NFT buy but once purchased they will only have a button to close the checkout.
Once shopping cart is implemented the selected quantity can be passed to cart as well, initially setting quantity of that cart NFT item to that quantity.