Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented single nft bulk buy #127

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

amenconi
Copy link
Contributor

On the NFT page, when applicable, an input will allow a quantity to be typed in or incremented/decremented using up/down arrows. When "Buy now" button is pressed the input quantity of NFTs is passed to the checkout drawer.

If a quantity of more than 1 is passed then it will display a warning informing the user that multiple NFTs have been selected to be purchased.

NFT purchase flow for user will be same as for single NFT buy but once purchased they will only have a button to close the checkout.

Once shopping cart is implemented the selected quantity can be passed to cart as well, initially setting quantity of that cart NFT item to that quantity.

@amenconi amenconi linked an issue Jan 26, 2024 that may be closed by this pull request
@amenconi amenconi self-assigned this Jan 26, 2024
@amenconi amenconi added the enhancement New feature or request label Jan 26, 2024
@amenconi amenconi changed the base branch from master to develop January 26, 2024 04:39
Copy link

cloudflare-workers-and-pages bot commented Jan 26, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 619b91d
Status: ✅  Deploy successful!
Preview URL: https://5ddb3d56.app-cqo.pages.dev
Branch Preview URL: https://amenconi-bulk-buy-single-nft.app-cqo.pages.dev

View logs

Copy link
Contributor

@adamunchained adamunchained left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me! Great effort. I think it's important we get some community members to test this. I'll reach out to the task force as well.

Right now cloud flare runs build for every PR (as might have noticed) and it generates random URL. This is against the TEST API atm. I'm unable to generate two Cloudflare instances for PR (one prod and one test). I think when you ask general audience to test this it'll be hard for them to test against the TEST database as there isn't much data. It'll be easier for them to test on the production data. They can always create dummy user.

I've changed the Cloudflare to connect these preview branches to PROD database. Let me know if you think I should revert it.

Test URL for this branch is available here: https://amenconi-bulk-buy-single-nft.app-cqo.pages.dev/

@adamunchained
Copy link
Contributor

adamunchained commented Jan 26, 2024

@SoonaverseTF - I'll wait for you to approve the testing and give green light for release! Please comment here once done.

@SoonaverseTF - please also determine the TOKEN reward so we can update CONTRIBUTORS.md and execute SOON distribution

@thenikoboxman
Copy link

Screenshot_20240215-200838

Not sure what would happen by an amount of 1.5

@amenconi
Copy link
Contributor Author

Pushed commit with fixes so that all typed and pasted values get rounded to whole integers that are closest within the valid range. Looks like the Cloudflare Pages build failed though, looks like reviewing logs for that require log in access for Cloudflare, if I need to make any changes to fix this please let me know. Thanks!

@adamunchained
Copy link
Contributor

@amenconi - would it make sense to merge this into #128 and merge this together into develop once it's all ready?

@amenconi
Copy link
Contributor Author

@amenconi - would it make sense to merge this into #128 and merge this together into develop once it's all ready?

Hi Adam. I think so. Once done I can add a bit of code so that choosing a quantity over more than 1 for an NFT on the NFT page will allow you to buy that number in NFT checkout or alternately add that quantity of the NFT to the cart.

Thanks.

@emmap3-do
Copy link
Contributor

@amenconi I run some tests, here is my feedback:

  • When I type in 1.7 it rounds to 2 automatically. But if I type in 1.2 it doesn't round to 1. It does not affect the process because the modal popup still works as if I typed 1, but still may be best to adjust. An alternative solution would be to prevent the dot "." to be typed in (same as how it works with "," and "-" right now).

  • May be nice to add the USD price next to the IOTA/SMR value in the checkout popup. This wasn't there before so it's an add for all cases (a single nft buy or set nft buy)

  • See image below, how it looks like for a single nft purchase (left) vs how it look like for multiple nft purchase (right). Could you adjust the right mockup so that the NFT picture looks the same as the left one? Also, please add a space (eg. margin bottom) to the yellow warning message so it doesn't 'touch' the gray box with price details.

image

  • I noticed that when you get to the last step and have to pay, the Bloom button is missing. Maybe because this PR is not merged yet or maybe because there is something wrong or missing, please check. Thanks!

@adamunchained adamunchained changed the base branch from develop to amenconi-shopping-cart February 20, 2024 17:51
@adamunchained
Copy link
Contributor

@amenconi - would it make sense to merge this into #128 and merge this together into develop once it's all ready?

Hi Adam. I think so. Once done I can add a bit of code so that choosing a quantity over more than 1 for an NFT on the NFT page will allow you to buy that number in NFT checkout or alternately add that quantity of the NFT to the cart.

Thanks.

sounds great, I've rebased to "amenconi-shopping-cart" but there seems to be conflict. Once you resolve them I'll merge.

@adamunchained
Copy link
Contributor

@amenconi I run some tests, here is my feedback:

  • When I type in 1.7 it rounds to 2 automatically. But if I type in 1.2 it doesn't round to 1. It does not affect the process because the modal popup still works as if I typed 1, but still may be best to adjust. An alternative solution would be to prevent the dot "." to be typed in (same as how it works with "," and "-" right now).
  • May be nice to add the USD price next to the IOTA/SMR value in the checkout popup. This wasn't there before so it's an add for all cases (a single nft buy or set nft buy)
  • See image below, how it looks like for a single nft purchase (left) vs how it look like for multiple nft purchase (right). Could you adjust the right mockup so that the NFT picture looks the same as the left one? Also, please add a space (eg. margin bottom) to the yellow warning message so it doesn't 'touch' the gray box with price details.

image

  • I noticed that when you get to the last step and have to pay, the Bloom button is missing. Maybe because this PR is not merged yet or maybe because there is something wrong or missing, please check. Thanks!

@amenconi / @amenconi - you can continue conversation about this one on the #128

@amenconi amenconi merged commit 2f0738a into amenconi-shopping-cart Feb 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Bulk Buy - single NFT collection Front end
4 participants