Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ScopeFinderTarget.java #2132

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

DannyGooo
Copy link
Contributor

The key issue here is the use of @nullable with void. This is problematic because:

  1. The @nullable annotation is meant to indicate that a method can return null
  2. However, void means the method doesn't return anything at all
  3. Therefore, @nullable on a void method is meaningless and incorrect

In most IDEs, this would likely trigger a warning because it's a nonsensical combination. The method itself (printing "in method") would work fine, but the annotation serves no purpose and is technically incorrect.

The key issue here is the use of @nullable with void. This is problematic because:

1. The @nullable annotation is meant to indicate that a method can return null
2. However, void means the method doesn't return anything at all
3. Therefore, @nullable on a void method is meaningless and incorrect

In most IDEs, this would likely trigger a warning because it's a nonsensical combination. The method itself (printing "in method") would work fine, but the annotation serves no purpose and is technically incorrect.
@StevenArzt StevenArzt merged commit 31aed29 into soot-oss:develop Dec 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants