Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.2.1 #481

Merged
merged 3 commits into from
Nov 11, 2024
Merged

v2.2.1 #481

merged 3 commits into from
Nov 11, 2024

Conversation

mikekks
Copy link
Member

@mikekks mikekks commented Nov 11, 2024

๐Ÿ‘ฉโ€๐Ÿ’ป Contents

  • v2.2.1

๐Ÿ“ Review Note

๐Ÿ“ฃ Related Issue

  • closed #

โœ… ์ ๊ฒ€์‚ฌํ•ญ

  • docker-compose.yml ํŒŒ์ผ์— ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜ ํ•œ API์˜ ํฌ์›Œ๋”ฉ์„ ๋ณ€๊ฒฝํ•ด์คฌ๋‚˜์š”?
  • Spring Secret ๊ฐ’์„ ์ˆ˜์ •ํ•˜๊ฑฐ๋‚˜ ์ถ”๊ฐ€ํ–ˆ๋‹ค๋ฉด Github Secret์—์„œ ์ˆ˜์ •์„ ํ•ด์คฌ๋‚˜์š”?
  • Nestjs Secret ๊ฐ’์„ ์ˆ˜์ •ํ•˜๊ฑฐ๋‚˜ ์ถ”๊ฐ€ํ–ˆ๋‹ค๋ฉด Docker-Compose.yml ํŒŒ์ผ ๋ฐ ์ธ์Šคํ„ด์Šค ๋‚ด๋ถ€์˜ .env ํŒŒ์ผ์„ ์ˆ˜์ •ํ–ˆ๋‚˜์š”?

* chore: yml ํŒŒ์ผ์—์„œ API ๊ฒฝ๋กœ๋ช…์„ ์ฃผ์ž…ํ•  ์ˆ˜ ์žˆ๋„๋ก ์„ธํŒ…

* refactor(MeetingV2Controller): ํ–‰์‚ฌ ์‹ ์ฒญ/์ผ๋ฐ˜ ๋ชจ์ž„ ์‹ ์ฒญ API ๋ถ„๋ฆฌ

* refactor(MeetingV2Service): ํ–‰์‚ฌ ์‹ ์ฒญ/์ผ๋ฐ˜ ๋ชจ์ž„ ์‹ ์ฒญ ๋น„์ฆˆ๋‹ˆ์Šค ๋กœ์ง ๋ถ„๋ฆฌ

* feat(MeetingV2Service): ๋ชจ์ž„ ์‹ ์ฒญ ์œ ํšจ์„ฑ ๊ฒ€์ฆ ์ฒ˜๋ฆฌ ๊ตฌํ˜„

- ํ–‰์‚ฌ ๋ชจ์ž„์— ์ผ๋ฐ˜ ๋ชจ์ž„ ์‹ ์ฒญ ์‹œ ์˜ˆ์™ธ์ฒ˜๋ฆฌ
- ์ผ๋ฐ˜ ๋ชจ์ž„์— ํ–‰์‚ฌ ๋ชจ์ž„ ์‹ ์ฒญ ์‹œ ์˜ˆ์™ธ์ฒ˜๋ฆฌ

* test(MeetingV2ServiceTest): ๋ฉ”์„œ๋“œ ๋„ค์ด๋ฐ ๋ณ€๊ฒฝ

* test(MeetingV2ServiceTest): ํ–‰์‚ฌ ๋ฐ ์ผ๋ฐ˜ ๋ชจ์ž„ ์‹ ์ฒญ ์˜ˆ์™ธ์ฒ˜๋ฆฌ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ถ”๊ฐ€

* chore: prod, dev ํ™˜๊ฒฝ๋ณ€์ˆ˜ ๋ถ„๋ฆฌ

* refactor: ์—๋Ÿฌ ๋ฉ”์‹œ์ง€ ์ˆ˜์ •

* chore: ํ™˜๊ฒฝ๋ณ€์ˆ˜ ๋„ค์ด๋ฐ ๋ณ€๊ฒฝ

- dev ํ™˜๊ฒฝ์ด๋ž‘ ์ผ์น˜
@mikekks mikekks added ๐Ÿš€ deployment ์ •๊ธฐ ๋ฐฐํฌ์™€ ๊ด€๋ จ๋œ ๋ผ๋ฒจ 3๏ธโƒฃ patch labels Nov 11, 2024
@mikekks mikekks self-assigned this Nov 11, 2024
Copy link

height bot commented Nov 11, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

๐Ÿ’กTip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

Hi there ๐Ÿ‘‹

Using this App for a private organization repository requires a paid subscription.

You can click Edit your plan on the Pull Request Size GitHub Marketplace listing to upgrade.

If you are a non-profit organization or otherwise can not pay for such a plan, contact me by creating an issue

@mikekks mikekks merged commit a2abdc3 into main Nov 11, 2024
2 checks passed
@hoonyworld hoonyworld changed the title chore: ๋ชจ์ž„ ๊ด€๋ จ ๊ฐœ์„  (#479) v2.2.1 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3๏ธโƒฃ patch ๐Ÿš€ deployment ์ •๊ธฐ ๋ฐฐํฌ์™€ ๊ด€๋ จ๋œ ๋ผ๋ฒจ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants