Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

피드 상세 뷰어 컴포넌트 뼈대 작성 #365

Merged
merged 4 commits into from
Sep 12, 2023
Merged

피드 상세 뷰어 컴포넌트 뼈대 작성 #365

merged 4 commits into from
Sep 12, 2023

Conversation

eunsukimme
Copy link
Member

@eunsukimme eunsukimme commented Jul 30, 2023 •
edited
Loading

🚩 관련 이슈

📋 작업 내용

  • 스토리북 설정을 수정했어요(globals.css, svgr webpack 적용)
  • 아이콘들을 추가헀어요
  • 피드 상세 뷰어 컴포넌트(FeedPostViewer) 및 스토리를 추가했어요

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 30, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f53ba2c
Status: ✅  Deploy successful!
Preview URL: https://789115ab.sopt-crew-dev-legacy.pages.dev
Branch Preview URL: https://feat--364.sopt-crew-dev-legacy.pages.dev

View logs

@eunsukimme eunsukimme temporarily deployed to development July 30, 2023 15:51 — with GitHub Actions Inactive
@eunsukimme eunsukimme changed the title [WIP] 피드 상세 뷰어 커포넌트 추가 [WIP] 피드 상세 뷰어 컴포넌트 추가 Aug 20, 2023
@eunsukimme eunsukimme changed the base branch from develop to feat/#362 August 20, 2023 07:13
@eunsukimme eunsukimme self-assigned this Aug 20, 2023
Base automatically changed from feat/#362 to develop September 9, 2023 08:49
@eunsukimme eunsukimme temporarily deployed to development September 9, 2023 08:50 — with GitHub Actions Inactive
@eunsukimme eunsukimme temporarily deployed to development September 9, 2023 09:26 — with GitHub Actions Inactive
@eunsukimme eunsukimme changed the title [WIP] 피드 상세 뷰어 컴포넌트 추가 피드 상세 뷰어 컴포넌트 뼈대 작성 Sep 9, 2023
@eunsukimme eunsukimme marked this pull request as ready for review September 9, 2023 09:30
100Gyeon
100Gyeon approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@100Gyeon 100Gyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했어용 👏👏👏

na-reum
na-reum approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@na-reum na-reum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eunsukimme eunsukimme merged commit bbd80a4 into develop Sep 12, 2023
@eunsukimme eunsukimme deleted the feat/#364 branch September 12, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@na-reum na-reum na-reum approved these changes

@100Gyeon 100Gyeon 100Gyeon approved these changes

@borimong borimong Awaiting requested review from borimong borimong is a code owner

Assignees

@eunsukimme eunsukimme

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

피드 상세 뷰어 컴포넌트 뼈대 작성
3 participants
@eunsukimme @na-reum @100Gyeon