Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

피드 상세 content 부분 모바일 대응 #398

Merged
merged 5 commits into from
Sep 17, 2023
Merged

피드 상세 content 부분 모바일 대응 #398

merged 5 commits into from
Sep 17, 2023

Conversation

borimong
Copy link
Contributor

@borimong borimong commented Sep 16, 2023 •
edited
Loading

🚩 관련 이슈

📋 작업 내용

  • 피드 상세의 content 부분 모바일 대응

📌 PR Point

  • 무슨 이유로 어떻게 코드를 변경했는지
  • @tablet 을 이용해서 모바일뷰 대응했습니다!
  • 어떤 위험이나 우려가 발견되었는지
  • 어떤 부분에 리뷰어가 집중해야 하는지
  • 개발하면서 어떤 점이 궁금했는지

📸 스크린샷

image

@borimong borimong temporarily deployed to development September 16, 2023 07:42 — with GitHub Actions Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 16, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 03db5f5
Status:⚡️  Build in progress...

View logs

@borimong borimong temporarily deployed to development September 16, 2023 07:51 — with GitHub Actions Inactive
@borimong borimong marked this pull request as ready for review September 17, 2023 05:15
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 17, 2023
@borimong borimong temporarily deployed to development September 17, 2023 05:25 — with GitHub Actions Inactive
eunsukimme
eunsukimme approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@eunsukimme eunsukimme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@borimong borimong merged commit f39f27e into develop Sep 17, 2023
@100Gyeon 100Gyeon deleted the feat/#394 branch February 5, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunsukimme eunsukimme eunsukimme approved these changes

@100Gyeon 100Gyeon Awaiting requested review from 100Gyeon

@na-reum na-reum Awaiting requested review from na-reum

Assignees

@borimong borimong

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

피드 상세 모바일뷰 피드 내용 UI 추가
2 participants
@borimong @eunsukimme