피드 상세 뷰 이미지 캐러셀 UI 추가 #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
a6b1cae
|
| Status: | ⚡️ Build in progress... |
eunsukimme
temporarily deployed
to
development
GitHub Actions
Inactive
eunsukimme
temporarily deployed
to
development
GitHub Actions
Inactive
100Gyeon
approved these changes
Sep 16, 2023
Comment on lines
+21
to
+28
| useEffect(() => { | ||
| if (!api) return; | ||
| api.on('select', () => setCurrentIndex(api.selectedScrollSnap() + 1)); | ||
|
|
||
| return () => { | ||
| api.destroy(); | ||
| }; | ||
| }, [api]); |
There was a problem hiding this comment.
이 부분 궁금해서 찾아봤는데 문서도 넘 친절하고 좋네요!
또 배워갑니다😊
eunsukimme
force-pushed
the
feat/#406
branch
from
cbc7a27
to
ea320d9
Compare
eunsukimme
temporarily deployed
to
development
GitHub Actions
Inactive
eunsukimme
force-pushed
the
feat/#406
branch
from
ea320d9
to
a6b1cae
Compare
eunsukimme
temporarily deployed
to
development
GitHub Actions
Inactive
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📋 작업 내용
embla-carousel-react를 추가했어요. 기존에 사용하는react-slick보다 가볍고 개발 경험이 좋아서 추가했어요(Github)ImageCarouselModal을 추가했어요OverlayProvider데코레이터를 추가했어요. 이제useOverlay을 사용하는 컴포넌트도 스토리북에서 볼 수 있어요.📌 PR Point
📸 스크린샷
Screen.Recording.2023-09-17.at.12.27.09.AM.mov