useMutationPostLike type에서 data 제거 #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
borimong
reviewed
Oct 9, 2024
src/api/post/hooks.ts
Outdated
| ? previousPost.data.likeCount && previousPost.data.likeCount - 1 | ||
| : previousPost.data.likeCount && previousPost.data.likeCount + 1; | ||
| const newLikeCount = previousPost.isLiked | ||
| ? previousPost.likeCount && previousPost.likeCount - 1 |
There was a problem hiding this comment.
슬랙에서도 이야기했었지만, 이렇게 될 경우 likeCount 가 0 이 될 때 falsy 한 값으로 처리되게 되어요. 그래서 제가 슬랙에 보내드린 사진처럼 || 0 을 활용하거나, 서버 api 에서 타입을 undefined | number > number 로 바꾸어주어야 해요~
There was a problem hiding this comment.
앗 네 ..! 서버 api 타입 변경까지 pending 하겠습니다!!
ocahs9
approved these changes
Oct 9, 2024
Comment on lines
+87
to
+88
| draft.isLiked = !previousPost.isLiked; | ||
| draft.likeCount = newLikeCount; |
There was a problem hiding this comment.
아 한번 더 감싸서 오는 에러가 있었구나..!
잘 찾아냈네요 굿굿
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📸 스크린샷
-잘 작동되는 거 확인했습니다!
2024-10-09.10.01.45.mov