Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#940 #944

Merged
merged 27 commits into from
Nov 3, 2024
Merged

Feat/#940 #944

merged 27 commits into from
Nov 3, 2024

Conversation

borimong
Copy link
Contributor

@borimong borimong commented Oct 31, 2024 •
edited
Loading

🚩 κ΄€λ ¨ 이슈

πŸ“‹ μž‘μ—… λ‚΄μš©

  • κΈ°λŠ₯ κ΅¬ν˜„
  • νŽ˜μ΄μ§€ ꡬ쑰화 및 μŠ€νƒ€μΌλ§

πŸ“Œ PR Point

  • 무슨 이유둜 μ–΄λ–»κ²Œ μ½”λ“œλ₯Ό λ³€κ²½ν–ˆλŠ”μ§€
  • μ–΄λ–€ μœ„ν—˜μ΄λ‚˜ μš°λ €κ°€ λ°œκ²¬λ˜μ—ˆλŠ”μ§€
  • μ–΄λ–€ 뢀뢄에 리뷰어가 집쀑해야 ν•˜λŠ”μ§€
  • κ°œλ°œν•˜λ©΄μ„œ μ–΄λ–€ 점이 κΆκΈˆν–ˆλŠ”μ§€

πŸ“Έ μŠ€ν¬λ¦°μƒ·

ocahs9 and others added 22 commits October 28, 2024 04:52
@ocahs9
feat: 곡동λͺ¨μž„μž₯ κΈ°λ³Έ ν‹€ κ΅¬ν˜„
b26fb37
@ocahs9
feat: button에 νƒ€μž… μ§€μ •ν•΄μ€˜μ„œ μ›μΉ˜ μ•ŠλŠ” submit μ•ˆλ˜λ„λ‘ λ°©μ§€ν•˜κΈ°
73ad3a2
@ocahs9
feat: λ©˜μ…˜μ„ ν¬ν•¨ν•œ input ν‹€ μ™„μ„±(μ™„μ „νžˆ λ””μžμΈ λ˜‘κ°™μ΄ κ΅¬ν˜„μ€ x)
f8906a7
@ocahs9
fix: +λ²„νŠΌ μ•žμ— κ³ μ •
67c3dbf
@ocahs9
design: inputμ°½ μ—΄λ €μžˆμ„ λ•Œ λ²„νŠΌ λ°μ•„μ§€λŠ” 것 μœ μ§€
d7d2fa7
@ocahs9
feat: λͺ¨μž„ κ°œμ„€ - 곡동 λͺ¨μž„μž₯ μΆ”κ°€ λ·°,κΈ°λŠ₯ κ΅¬ν˜„ μ™„λ£Œ
27d7a6b
@ocahs9
design: ν”Όκ·Έλ§ˆμƒμ—μ„œλŠ” 8px둜 λ˜μ–΄μžˆμ–΄μ„œ μˆ˜μ •
084b75e
@ocahs9
design: mobile λ°˜μ‘ν˜• λ””μžμΈ κ΅¬ν˜„
e3c86d0
@ocahs9
fix: coLeader.map is not a function 버그 ν•΄κ²°
b793d91
@ocahs9
feat: λͺ¨λ°”일 λ©˜μ…˜ λ°”ν…€μ‹œνŠΈ κ΅¬ν˜„
af213c0
@ocahs9
design: λͺ¨μž„μž₯ ν”„λ‘œν•„ λ””μžμΈ λ³€κ²½
f0a3a96
@ocahs9
design: λΆˆν•„μš”ν•œ margin 제거
2a64b65
@ocahs9
chore: 이해λ₯Ό λ•λŠ” 주석 첨가, λΆˆν•„μš”ν•œ μ½˜μ†” 제거
10dae42
@borimong
update: API 버전 μ΅œμ‹ ν™”
a62a4ce
@borimong
fix: μ›Ήλ·°-ν”Όλ“œ μž‘μ„± λͺ¨λ‹¬ λ¬΄ν•œ λ Œλ”λ§ 이슈
c381332
@borimong
update: λ©˜μ…˜ μœ μ € 리슀트 쑰회 API μ΅œμ‹ ν™”
7ae607e
@borimong
feat: isCoLeader λ³€μˆ˜ μΆ”κ°€
f1fc140
@borimong
Merge branch 'feat/#936' of https://github.com/sopt-makers/sopt-crew-…
9b05b4b 
…frontend into feat/#940
@borimong
update: API μ΅œμ‹ ν™” (approvedCount)
8533976
@borimong
feat: λ©˜μ…˜ νƒ€μž…μ— userId μΆ”κ°€
6104476
@borimong
feat: isCoLeader 선택적 νƒ€μž… μ •μ˜
f6246b5
@borimong
feat: formData에 coLeaderUserIds μΆ”κ°€
cb183e0
@height Height
Copy link

height bot commented Oct 31, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

πŸ’‘Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@borimong borimong marked this pull request as ready for review November 3, 2024 07:47
@borimong borimong merged commit fabcf36 into develop Nov 3, 2024
2 checks passed
@borimong borimong deleted the feat/#940 branch November 3, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-nary j-nary Awaiting requested review from j-nary j-nary is a code owner

@ocahs9 ocahs9 Awaiting requested review from ocahs9 ocahs9 is a code owner

Assignees

@borimong borimong

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

곡동λͺ¨μž„μž₯ API 반영
2 participants
@borimong @ocahs9