Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API 마이그레이션 마무리 #953

Merged
merged 9 commits into from
Nov 13, 2024
Merged

API 마이그레이션 마무리 #953

merged 9 commits into from
Nov 13, 2024

Conversation

j-nary
Copy link
Member

@j-nary j-nary commented Nov 13, 2024

🚩 관련 이슈

📋 작업 내용

  • 모임 삭제
  • 지원자 상태변경
  • 로그인

j-nary and others added 7 commits October 21, 2024 23:48
* Chip 파트 한 개 이슈 대응 (#932)

* test: 임시로 Chip 구현 (MDS 문의 필요)

* feat: chip 구현 및 반응형 작업

* feat: 전체파트 클릭 로직 + MDS Chip 연결

* docs: 불필요한 파일 삭제

* docs: 불필요한 코드 삭제

* fix: 개별 옵션 해제 시 전체파트 해제 로직 추가

* refactor: 코드리뷰 반영

* refactor: input 높이 반응형 제거

* feat: 모임 안내 모집 대상 chip 변경

* style: 색상변경

* style: QA 반영

* fix: 이슈대응

* fix: Chip 한개 선택 이슈 대응

* fix: Chip 5개 선택 시 이슈 해결 (#934)

* feat: 모임 삭제 dialog mds 마이그레이션 (#937)
@j-nary j-nary self-assigned this Nov 13, 2024
Copy link

height bot commented Nov 13, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@@ -210,7 +210,7 @@ export const getMeetingPeopleList = async ({ id, ...rest }: OptionData): Promise
};

export const deleteMeeting = async (id: number): Promise<{ statusCode: number }> => {
return (await api.delete<{ statusCode: number }>(`/meeting/${id}`)).data;
return (await api.delete<{ statusCode: number }>(`/meeting/v2/${id}`)).data;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

statusCode 는 필요 없을 거에요! 확인 부탁합니다~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 반영 완료했습니다 !

Copy link
Contributor

@borimong borimong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! API 마이그레이션 하느라 고생했어요~

@j-nary j-nary merged commit 480c484 into develop Nov 13, 2024
1 check passed
@j-nary j-nary deleted the refactor/#952 branch November 13, 2024 16:00
j-nary added a commit that referenced this pull request Nov 14, 2024
j-nary added a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API 마이그레이션 마무리
2 participants