Fixed safe division

sora-xor · Sep 20, 2023 · e88017d · e88017d
1 parent fa06f70
commit e88017d
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/build.gradle b/build.gradle
@@ -44,7 +44,7 @@ buildscript {
             composeMaterial        : '1.4.3',
             composeCompiler        : '1.4.6',
             composeConstraintLayout: '1.1.0-alpha05',
-            uiCore                 : '0.1.3',
+            uiCore                 : '0.1.4',
             soraCard               : '0.1.41',
             lazySodium             : '5.0.2',
             jna                    : '5.8.0',

diff --git a/...rc/main/java/jp/co/soramitsu/common_wallet/presentation/compose/util/PolkaswapFormulas.kt b/...rc/main/java/jp/co/soramitsu/common_wallet/presentation/compose/util/PolkaswapFormulas.kt
@@ -82,8 +82,8 @@ object PolkaswapFormulas {
     ): BigDecimal {
         return pooled
             .plus(amount)
-            .safeDivide(amount.plus(reserves))
             .multiply(Big100)
+            .safeDivide(amount.plus(reserves))
     }
 
     fun estimateRemovingShareOfPool(
@@ -92,8 +92,8 @@ object PolkaswapFormulas {
         reserves: BigDecimal
     ): BigDecimal = pooled
         .minus(amount)
-        .safeDivide(reserves.minus(amount))
         .multiply(Big100)
+        .safeDivide(reserves.minus(amount))
 
     fun calculateMinAmount(
         amount: BigDecimal,
@@ -133,5 +133,6 @@ object PolkaswapFormulas {
         amount: BigDecimal,
         amountPooled: BigDecimal,
         otherPooled: BigDecimal,
-    ): BigDecimal = amount.multiply(otherPooled).safeDivide(amountPooled)
+        precision: Int
+    ): BigDecimal = amount.multiply(otherPooled).safeDivide(amountPooled).safeDivide(Big100, precision)
 }
diff --git a/..._wallet/src/test/java/jp/co/soramitsu/common_wallet/presentation/PolkaswapFormulasTest.kt b/..._wallet/src/test/java/jp/co/soramitsu/common_wallet/presentation/PolkaswapFormulasTest.kt
@@ -128,8 +128,8 @@ class PolkaswapFormulasTest {
     fun `test estimateAddingShareOfPool`() {
         val shareOfPool = SECOND_POOLED
             .plus(TARGET_AMOUNT)
-            .safeDivide(TARGET_AMOUNT.plus(RESERVES_SECOND))
             .multiply(Big100)
+            .safeDivide(TARGET_AMOUNT.plus(RESERVES_SECOND))
 
         assertEquals(
             shareOfPool,
@@ -145,8 +145,8 @@ class PolkaswapFormulasTest {
     fun `test estimateRemovingShareOfPool`() {
         val shareOfPool = SECOND_POOLED
             .minus(TARGET_AMOUNT)
-            .safeDivide(RESERVES_SECOND.minus(TARGET_AMOUNT))
             .multiply(Big100)
+            .safeDivide(RESERVES_SECOND.minus(TARGET_AMOUNT))
 
         assertEquals(
             shareOfPool,

diff --git a/...u/feature_polkaswap_impl/presentation/screens/liquidityremove/LiquidityRemoveViewModel.kt b/...u/feature_polkaswap_impl/presentation/screens/liquidityremove/LiquidityRemoveViewModel.kt
@@ -320,6 +320,7 @@ class LiquidityRemoveViewModel @AssistedInject constructor(
                             amount1,
                             it.user.basePooled,
                             it.user.targetPooled,
+                            removeState.assetState2?.token?.precision ?: 18
                         )
                         percent = PolkaswapFormulas.calculateShareOfPoolFromAmount(
                             amount1,
@@ -344,7 +345,8 @@ class LiquidityRemoveViewModel @AssistedInject constructor(
                             PolkaswapFormulas.calculateOneAmountFromAnother(
                                 amount2,
                                 it.user.targetPooled,
-                                it.user.basePooled
+                                it.user.basePooled,
+                                removeState.assetState1?.token?.precision ?: 18
                             )
                         percent = PolkaswapFormulas.calculateShareOfPoolFromAmount(
                             amount1,