Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that on windows the url are actually rendered with \ instead of proper url /.
Test pass, as far as I can tell. ( On windows I had to adapt the tests expected strings to something account for platform separator.
in order to make it work. Since paths on windows are
\\
instead of the/
that is used in unix paths.This fix should fix following scenarios:
FROM:
TO:
Note: it was not really affecting the loading of the resource, however, I prefer universal url format style in this case.
Also note: As I looked into the copy mode, I realise that normalizeSlashes does nothing for it, however, if there will ever be the case where, just like @rollup/plugin-url, a [dirname] naming option will be included, the url should still look nice ( i hope so )