fix incorrect import path in copy + preserveModules mode #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using copy + preserveModules, the final import path was incorrect:
e.g. dir structure:
so the original import was
./assets/fancy-asset.svg
after building, the structure was:
but the import path was
../../../assets/fancy-assets.svg
instead of../../assets/fancy-assets.svg
.The reason was that the final path was calculated based on the "wrapper file" (i.e.
src/components/ComponentA/assets/fanc-asset.svg.js
) instead of the importing file - I changed the implementation and the existing test.Let me know if that's fine or perhaps if I should leave the existing case and just add a new one.