Skip to content

Commit

Permalink
Merge pull request #28 from sorry-cypress/allow-ingress-path-customiz…
Browse files Browse the repository at this point in the history
…ation

Allow ingress path customization
  • Loading branch information
fsmaia authored Jan 29, 2021
2 parents eddbac2 + 7637947 commit cbd5141
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 6 deletions.
2 changes: 1 addition & 1 deletion charts/sorry-cypress/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: sorry-cypress
description: A Helm chart for Sorry Cypress
type: application
version: 0.1.23
version: 0.1.24
appVersion: 0.6.1
home: https://sorry-cypress.dev/
sources:
Expand Down
2 changes: 2 additions & 0 deletions charts/sorry-cypress/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ https://sorry-cypress.dev/api#configuration
| `api.ingress.labels` | Ingress labels | `{}` |
| `api.ingress.annotations` | Ingress annotations | `{}` |
| `api.ingress.hosts[0].host` | Hostname to the service installation | `api.chart-example.local` |
| `api.ingress.hosts[0].path` | Root path to the service installation | `/` |
| `api.ingress.tls` | Ingress secrets for TLS certificates | `[]` |

### Dashboard service
Expand All @@ -92,6 +93,7 @@ https://sorry-cypress.dev/dashboard#configuration
| `dashboard.ingress.labels` | Ingress labels | `{}` |
| `dashboard.ingress.annotations` | Ingress annotations | `{}` |
| `dashboard.ingress.hosts[0].host` | Hostname to the service installation | `dashboard.chart-example.local` |
| `dashboard.ingress.hosts[0].path` | Root path to the service installation | `/` |
| `dashboard.ingress.tls` | Ingress secrets for TLS certificates | `[]` |

### Director service
Expand Down
5 changes: 3 additions & 2 deletions charts/sorry-cypress/templates/ingress-api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,16 @@ spec:
http:
paths:
{{- if $v1Networking }}
- path: /
- path: {{ .path | default "/" }}
pathType: Prefix
backend:
service:
name: {{ $fullName }}-api
port:
number: {{ $servicePort }}
{{- else }}
- backend:
- path: {{ .path | default "/" }}
backend:
serviceName: {{ $fullName }}-api
servicePort: {{ $servicePort }}
{{- end }}
Expand Down
5 changes: 3 additions & 2 deletions charts/sorry-cypress/templates/ingress-dashboard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,16 @@ spec:
http:
paths:
{{- if $v1Networking }}
- path: /
- path: {{ .path | default "/" }}
pathType: Prefix
backend:
service:
name: {{ $fullName }}-dashboard
port:
number: {{ $servicePort }}
{{- else }}
- backend:
- path: {{ .path | default "/" }}
backend:
serviceName: {{ $fullName }}-dashboard
servicePort: {{ $servicePort }}
{{- end }}
Expand Down
3 changes: 2 additions & 1 deletion charts/sorry-cypress/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ api:
# kubernetes.io/tls-acme: "true"
hosts:
- host: api.chart-example.local
path: /
tls: []
# - secretName: chart-example-tls
# hosts:
Expand Down Expand Up @@ -84,7 +85,7 @@ dashboard:
# kubernetes.io/tls-acme: "true"
hosts:
- host: dashboard.chart-example.local
paths: /
path: /
tls: []
# - secretName: chart-example-tls
# hosts:
Expand Down

0 comments on commit cbd5141

Please sign in to comment.