[avocado_tests] added default_mapping test

[dtzhou2]

Added default mapping test and made it so all cleaner tests have the --no-update option as in issue #3254

Close #3254

Signed-off-by: Daniel Zhou [email protected]

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• [X ] Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• [ X] Is the subject and message clear and concise?
• Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• [ X] Does the commit contain a Signed-off-by: First Lastname [email protected]?
• [ X] Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/sosreport-sos-3286
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[arif-ali]

Can you rebase to main branch please, which has the fix for the snap build

Also follow the guidelines and add the Signed-off-by line at the bottom, which can easily be done via git commit -s ...

Also add the Closes: line to the issue that it closes and resolves

[pmoravec]

What file you refer to here? When I run this test I get:

(1/8) tests/cleaner_tests/full_report/full_report_run.py:FullCleanTest.test_default_mapping: ERROR: [Errno 2] No such file or directory: 'default_mapping' (2.26 s)

Also I dont understand what you aim to compare here. self.files[0][1] should be /etc/sos/cleaner/default_mapping which will be populated (from scratch) by a mapping of sos report --clean - what content are you trying to compare with?

Maybe it makes sense to check if the file contains (some? all?) from hostname_map / ip_map / ipv6_map / mac_map / keyword_map / username_map strings (which should be in fact keys for nested maps)?

[dtzhou2]

Yea that was what I was going for but I did not consider that default_mapping would generate machine specific information. Updating commit to change that

[pmoravec]

Can't we simply:

self.assertNotEqual(ref_data.count("_map"), 0)

?

Also please squash this commit into the other one.

[pmoravec]

Furter, could you please add the --no-update also to:

• https://github.com/sosreport/sos/blob/main/tests/cleaner_tests/skip_versioning/skip_version_ip_parser.py#L26
• https://github.com/sosreport/sos/blob/main/tests/report_tests/encryption_tests.py#L42
• https://github.com/sosreport/sos/blob/main/tests/vendor_tests/redhat/rhbz1950350/rhbz1950350.py#L26

? To have it covered in any --clean usage (up to the one necessary test). Thanks in advance.

[TurboTurtle]

This looks mostly correct - just echoing Pavel's comments above. Additionally please add a DCO line (you can do this with git commit -s or git commit -s --amend)

[TurboTurtle]

/packit retest-failed

[dtzhou2]

dont know whats broken here. Build just says there is a merge conflict

[TurboTurtle]

There's a merge conflict with tests/cleaner_tests/basic_function_tests/report_with_mask.py - from 02d52f7 which already added --no-update here.

[pmoravec]

Isn't this line redundant?

[pmoravec]

ACK up to the one redundant line.

[arif-ali]

@dtzhou2 are you still working on this PR?