Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[process] Collect process stat files #3697

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rh-jhester
Copy link

The /proc/ subdirectory for a process contains many files, most of which the report doesn't capture. One of those files is stat, which contains, among other pieces of information, the CPU on which the process is running. This information is not contained in any of the files that the report currently collects, and is important for troubleshooting, e.g., isolcpus or other scheduling issues. The status file contains the field Cpus_allowed and Cpus_allowed_list, but this is not the same information. The underlying task_struct has separate members for the current CPU and the allowed CPU mask (list). The stat file is quite small and should be included in the report since it contains important information not contained elsewhere.

Signed-off-by: Jesse Hester [email protected]

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • [ X] Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • [ X] Is the subject and message clear and concise?
  • [ X] Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • [ X] Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • [ X] Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • [ X] Are all passwords or private data gathered by this PR obfuscated?

Signed-off-by: Jesse Hester <[email protected]>
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3697
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@rh-jhester
Copy link
Author

After submitting this PR I noticed that the CPU that each process is running on is included in the output of the pidstat commands. We may want to include the stat files anyway--especially if we thought that the status files contained equivalent information--but the use case that prompted me to create the PR is technically invalidated.

@arif-ali
Copy link
Member

@rh-jhester is still something you're working on?

@jcastill jcastill added the RedHat Eng Red Hat Engineering for review label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RedHat Eng Red Hat Engineering for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants