Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle session tokens in generatePresignedPost #716

Merged
merged 3 commits into from
Apr 23, 2024
Merged

fix: handle session tokens in generatePresignedPost #716

merged 3 commits into from
Apr 23, 2024

Conversation

nicksloan
Copy link
Contributor

Checks for the presence of a session token, and adds it to the presigned-POST request if it exists.

@nicksloan nicksloan changed the title fix: handle session tokens fix: handle session tokens in generatePresignedPost Apr 23, 2024
@nicksloan nicksloan changed the base branch from main to 7.x.x April 23, 2024 11:50
@nicksloan nicksloan changed the base branch from 7.x.x to main April 23, 2024 11:52
@adam-fowler
Copy link
Member

@nicksloan Have you tested this in the real world yet?

@nicksloan
Copy link
Contributor Author

@adam-fowler Just confirmed it works.

adam-fowler
adam-fowler approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@adam-fowler adam-fowler merged commit 58634b7 into soto-project:main Apr 23, 2024
6 checks passed
@nicksloan nicksloan deleted the fix-session-token branch April 23, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-fowler adam-fowler adam-fowler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicksloan @adam-fowler