feat: add vscode slice for message passing with extension #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichDom2185
reviewed
Jan 20, 2025
Pull Request Test Coverage Report for Build 13177704939Details
💛 - Coveralls |
RichDom2185
reviewed
Feb 4, 2025
Comment on lines
+188
to
+192
| // useEffect(() => { | ||
| // // TODO: Hardcoded to make use of the first editor tab. Refactoring is needed for this workspace to enable Folder mode. | ||
| // handleEditorValueChange(0, ''); | ||
| // // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| // }, []); |
There was a problem hiding this comment.
Will this break anything with assessments? Have you tested locally?
There was a problem hiding this comment.
From my local testing, there's no unintended behavior. Assessments still loading as per normal.
handleEditorValueChange is ultimately called with the editor contents due to the useEffect here.
src/commons/workspace/Workspace.tsx
Outdated
| @@ -222,7 +223,11 @@ const Workspace: React.FC<WorkspaceProps> = props => { | |||
| </Resizable> | |||
| <div className="row content-parent" ref={contentContainerDiv}> | |||
| <div className="editor-divider" ref={editorDividerDiv} /> | |||
| <Resizable {...editorResizableProps()}>{createWorkspaceInput(props)}</Resizable> | |||
| {isVscode ? ( | |||
| <div style={{ width: '0px' }}>{createWorkspaceInput(props)}</div> | |||
There was a problem hiding this comment.
It must still be visible is it? We can't use visibility: hidden? If we can't, then in addition to width: 0, should we also use overflow: hidden?
There was a problem hiding this comment.
While visibility: hidden wouldn't work, I think we can completely remove it now that messages are passed directly to the redux store rather than to the editor.
Co-authored-by: Richard Dominick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FYP: Source Academy as Visual Studio Code Extension
This PR makes the frontend's behavior change conditionally when it detects itself to be running as an iframe in the VS Code extension. This is required so that it can send and receive the editor text contents, encapsulated as messages, to the VS Code extension.
Type of change
How to test
Checklist