Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump phaser justatin555 #3087

Closed
wants to merge 3 commits into from
Closed

Bump phaser justatin555 #3087

wants to merge 3 commits into from

Conversation

JustATin555
Copy link

@JustATin555 JustATin555 commented Feb 4, 2025

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

  • yarn test all tests passed
  • yarn start loads and story chapters can be entered
  • Tested with actual Source Academy chapters

Checklist

  • I have tested this code
  • I have updated the documentation

@JustATin555 JustATin555 closed this Feb 4, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do this, ! should only be used if you are absolutely sure it exists, so the comments are redundant.

Instead, either justify in the comments why you are absolutely sure it exists, or trust TS and use a guard (refer to what I had wrote last time in https://github.com/source-academy/frontend/pull/2940/files#diff-ab85a8652b937231da028317f53a4b2413b3833e76a7bb077c41c1011b9f47fe)

@RichDom2185
Copy link
Member

Supersedes #2940

@JustATin555
Copy link
Author

Will redo with merged commit from GM Hartin Menz.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13135268057

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.196%

Totals Coverage Status
Change from base Build 13133948412: 0.0%
Covered Lines: 4842
Relevant Lines: 14646

💛 - Coveralls

@JustATin555 JustATin555 deleted the bump-phaser-justatin555 branch February 4, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants