Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSE Machine: Fix display bug when scanning out declarations #1527

Merged
merged 14 commits into from
Feb 5, 2024
Merged

CSE Machine: Fix display bug when scanning out declarations #1527

merged 14 commits into from
Feb 5, 2024

Conversation

DiligentPenguinn
Copy link
Contributor

@DiligentPenguinn DiligentPenguinn commented Feb 2, 2024 •
edited by RichDom2185
Loading

Description

This PR resolves #1503 . These are the changes implemented on the js-slang side

Changes

  • Change initial values binded to keys from DECLARED_BUT_NOT_YET_ASSIGNED to UNASSIGNED_CONST and UNASSIGNED_LET, which contains extra information about declaration type

@DiligentPenguinn DiligentPenguinn added the Bug Something isn't working label Feb 2, 2024
@DiligentPenguinn DiligentPenguinn self-assigned this Feb 2, 2024
@RichDom2185 RichDom2185 mentioned this pull request Feb 2, 2024
Merged
1 task
martin-henz
martin-henz requested changes Feb 5, 2024
View reviewed changes
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many test cases show regressions. Need to take another look.

src/cse-machine/__tests__/__snapshots__/cse-machine-errors.ts.snap Outdated Show resolved Hide resolved
src/cse-machine/__tests__/__snapshots__/cse-machine-errors.ts.snap Outdated Show resolved Hide resolved
src/cse-machine/__tests__/__snapshots__/cse-machine-errors.ts.snap Outdated Show resolved Hide resolved
src/cse-machine/__tests__/__snapshots__/cse-machine-errors.ts.snap Outdated Show resolved Hide resolved
src/cse-machine/__tests__/__snapshots__/cse-machine-errors.ts.snap Outdated Show resolved Hide resolved
src/cse-machine/__tests__/__snapshots__/cse-machine-errors.ts.snap Outdated Show resolved Hide resolved
src/cse-machine/__tests__/__snapshots__/cse-machine-errors.ts.snap Outdated Show resolved Hide resolved
src/cse-machine/__tests__/__snapshots__/cse-machine-errors.ts.snap Outdated Show resolved Hide resolved
src/cse-machine/__tests__/__snapshots__/cse-machine-errors.ts.snap Outdated Show resolved Hide resolved
src/cse-machine/__tests__/__snapshots__/cse-machine-errors.ts.snap Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Feb 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7785707171

  • 0 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 83.054%
Totals Coverage Status
Change from base Build 7778702350: 0.01%
Covered Lines: 10928
Relevant Lines: 12734
💛 - Coveralls

martin-henz
martin-henz approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good now.

@martin-henz martin-henz merged commit ddeb915 into master Feb 5, 2024
4 checks passed
@martin-henz martin-henz deleted the cse-issue1503 branch February 5, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-henz martin-henz martin-henz approved these changes

@RichDom2185 RichDom2185 Awaiting requested review from RichDom2185

Assignees

@DiligentPenguinn DiligentPenguinn

Labels
Bug Something isn't working
Projects
No open projects
SA 2425 CP3108 P03: CSE Machine
Status: Done
Milestone
No milestone
4 participants
@DiligentPenguinn @coveralls @martin-henz @RichDom2185