-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize line encodings #210
Closed
Yongbeom-Kim
wants to merge
13
commits into
source-academy:master
from
Yongbeom-Kim:standardize-line-encodings
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
706b4aa
minimal wasm MVP
Yongbeom-Kim 980ba22
Add comments for module methods
Yongbeom-Kim a3c96dc
Add documentation
Yongbeom-Kim 344abb9
Change line endings to windows
Yongbeom-Kim d8ddc16
Fix eslint
Yongbeom-Kim 83128d2
Update dependency
Yongbeom-Kim 37d1f54
Merge branch 'master' into master
Yongbeom-Kim acddad3
replace line ending
Yongbeom-Kim 128a08b
Merge branch 'master' of https://github.com/Yongbeom-Kim/source-acade…
Yongbeom-Kim e92f640
Merge branch 'master' into master
Yongbeom-Kim ec37780
add .gitattributes file for line endings + save before --renormalise
Yongbeom-Kim 6c7946a
Normalize all the line endings
Yongbeom-Kim becb6f8
Merge branch 'master' into standardize-line-encodings
Yongbeom-Kim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
## Standardize line encodings | ||
## Src: https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings#per-repository-settings | ||
# Set the default behavior, in case people don't have core.autocrlf set. | ||
* text=auto | ||
|
||
# Declare files that will always have CRLF line endings on checkout. | ||
*.js text eof=crlf | ||
*.ts text eof=crlf | ||
*.tsx text eof=crlf | ||
*.md text eof=crlf | ||
*.cjs text eof=crlf | ||
*.json text eof=crlf | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,46 +1,46 @@ | ||
--- | ||
name: Bug Report | ||
about: Use this template for highlighting bugs. | ||
title: '[FEATURE NAME]: [BUG SUMMARY]' | ||
labels: bug | ||
--- | ||
# Prerequisites | ||
Please answer the following questions for yourself before submitting an issue. **YOU MAY DELETE THE PREREQUISITES SECTION.** | ||
- [ ] I am running the latest version | ||
- [ ] I checked the documentation and found no answer | ||
- [ ] I checked to make sure that this issue has not already been filed | ||
# Expected Behavior | ||
Please describe the behavior you are expecting | ||
# Current Behavior | ||
What is the current behavior? | ||
# Failure Information (for bugs) | ||
Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template. | ||
## Steps to Reproduce | ||
Please provide detailed steps for reproducing the issue. | ||
1. step 1 | ||
2. step 2 | ||
3. you get it... | ||
## Context | ||
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions. | ||
- Version used: <!-- Indicate the commit hash --> | ||
- Browser Name and version: | ||
- Operating System and version (desktop or mobile): | ||
## Failure Logs | ||
Please include any relevant log snippets or files here. | ||
--- | ||
name: Bug Report | ||
about: Use this template for highlighting bugs. | ||
title: '[FEATURE NAME]: [BUG SUMMARY]' | ||
labels: bug | ||
--- | ||
|
||
# Prerequisites | ||
|
||
Please answer the following questions for yourself before submitting an issue. **YOU MAY DELETE THE PREREQUISITES SECTION.** | ||
|
||
- [ ] I am running the latest version | ||
- [ ] I checked the documentation and found no answer | ||
- [ ] I checked to make sure that this issue has not already been filed | ||
|
||
# Expected Behavior | ||
|
||
Please describe the behavior you are expecting | ||
|
||
# Current Behavior | ||
|
||
What is the current behavior? | ||
|
||
# Failure Information (for bugs) | ||
|
||
Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template. | ||
|
||
## Steps to Reproduce | ||
|
||
Please provide detailed steps for reproducing the issue. | ||
|
||
1. step 1 | ||
2. step 2 | ||
3. you get it... | ||
|
||
## Context | ||
|
||
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions. | ||
|
||
- Version used: <!-- Indicate the commit hash --> | ||
- Browser Name and version: | ||
- Operating System and version (desktop or mobile): | ||
|
||
## Failure Logs | ||
|
||
Please include any relevant log snippets or files here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,15 @@ | ||
--- | ||
name: Wiki Documentation Request | ||
about: Use this template for requesting documentation on a feature in the wiki. | ||
title: '[Wiki]: [FEATURE]' | ||
labels: documentation | ||
--- | ||
# Feature | ||
Please briefly describe the feature that needs documentation. | ||
## Checklist | ||
- [ ] I checked the documentation and found that it does not already exist | ||
- [ ] I checked to make sure that this issue has not already been filed | ||
--- | ||
name: Wiki Documentation Request | ||
about: Use this template for requesting documentation on a feature in the wiki. | ||
title: '[Wiki]: [FEATURE]' | ||
labels: documentation | ||
--- | ||
|
||
# Feature | ||
|
||
Please briefly describe the feature that needs documentation. | ||
|
||
## Checklist | ||
|
||
- [ ] I checked the documentation and found that it does not already exist | ||
- [ ] I checked to make sure that this issue has not already been filed |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,32 @@ | ||
# Description | ||
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. | ||
Fixes # (issue) | ||
## Type of change | ||
Please delete options that are not relevant. | ||
- [ ] Bug fix (non-breaking change which fixes an issue) | ||
- [ ] New feature (non-breaking change which adds functionality) | ||
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) | ||
- [ ] This change requires a documentation update | ||
# How Has This Been Tested? | ||
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. | ||
- [ ] Test A | ||
- [ ] Test B | ||
# Checklist: | ||
- [ ] My code follows the style guidelines of this project | ||
- [ ] I have performed a self-review of my own code | ||
- [ ] I have commented my code, particularly in hard-to-understand areas | ||
- [ ] I have made corresponding changes to the documentation | ||
- [ ] My changes generate no new warnings | ||
- [ ] I have added tests that prove my fix is effective or that my feature works | ||
- [ ] New and existing unit tests pass locally with my changes | ||
- [ ] Any dependent changes have been merged and published in downstream modules | ||
# Description | ||
|
||
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. | ||
|
||
Fixes # (issue) | ||
|
||
## Type of change | ||
|
||
Please delete options that are not relevant. | ||
|
||
- [ ] Bug fix (non-breaking change which fixes an issue) | ||
- [ ] New feature (non-breaking change which adds functionality) | ||
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) | ||
- [ ] This change requires a documentation update | ||
|
||
# How Has This Been Tested? | ||
|
||
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. | ||
|
||
- [ ] Test A | ||
- [ ] Test B | ||
|
||
# Checklist: | ||
|
||
- [ ] My code follows the style guidelines of this project | ||
- [ ] I have performed a self-review of my own code | ||
- [ ] I have commented my code, particularly in hard-to-understand areas | ||
- [ ] I have made corresponding changes to the documentation | ||
- [ ] My changes generate no new warnings | ||
- [ ] I have added tests that prove my fix is effective or that my feature works | ||
- [ ] New and existing unit tests pass locally with my changes | ||
- [ ] Any dependent changes have been merged and published in downstream modules |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#!/bin/sh | ||
. "$(dirname "$0")/_/husky.sh" | ||
yarn build --tsc --lint | ||
#!/bin/sh | ||
. "$(dirname "$0")/_/husky.sh" | ||
|
||
yarn build --tsc --lint |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,17 @@ | ||
{ | ||
"configurations": [ | ||
{ | ||
"type": "node", | ||
"name": "Test Scripts", | ||
"request": "launch", | ||
"args": [ | ||
"test", | ||
"--runInBand", | ||
"--config=${cwd}/scripts/src/jest.config.js" | ||
], | ||
"console": "integratedTerminal", | ||
"internalConsoleOptions": "neverOpen", | ||
"runtimeExecutable": "yarn" | ||
} | ||
] | ||
{ | ||
"configurations": [ | ||
{ | ||
"type": "node", | ||
"name": "Test Scripts", | ||
"request": "launch", | ||
"args": [ | ||
"test", | ||
"--runInBand", | ||
"--config=${cwd}/scripts/src/jest.config.js" | ||
], | ||
"console": "integratedTerminal", | ||
"internalConsoleOptions": "neverOpen", | ||
"runtimeExecutable": "yarn" | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
{ | ||
"eslint.workingDirectories": [ | ||
"src", | ||
"scripts/src" | ||
], | ||
"files.eol": "\r\n", | ||
{ | ||
"eslint.workingDirectories": [ | ||
"src", | ||
"scripts/src" | ||
], | ||
"files.eol": "\r\n", | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
export default new Proxy({}, { | ||
get: () => (input) => input, | ||
export default new Proxy({}, { | ||
get: () => (input) => input, | ||
}) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think there's a typo here: