Use range iterator for users list view

view/users/list.go

@@ -15,14 +15,14 @@ type ListView struct {
 
 func ListFrom(users []model.User, roles []groupenums.Role) []ListView {
 	usersListView := make([]ListView, len(users))
-	for i := 0; i < len(users); i++ {
+	for i, user := range users {
 		usersListView[i] = ListView{
 			// Unlike other views, we do not fallback an empty name to
 			// the username for the users' list view.
-			ID:            users[i].ID,
-			Name:          users[i].FullName,
-			Username:      users[i].Username,
-			LoginProvider: users[i].LoginProvider.ToString(),
+			ID:            user.ID,
+			Name:          user.FullName,
+			Username:      user.Username,
+			LoginProvider: user.LoginProvider.ToString(),
 			Role:          roles[i],
 		}
 	}