Skip to content

Commit

Permalink
node version update (#73)
Browse files Browse the repository at this point in the history
## Description

node version update from 16 to 18

Fixes # (issue)

## Type of change

Please delete options that are not relevant.

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Intermediate change (work in progress)

## How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration

- [ ] Test A
- [ ] Test B

## Checklist:

- [ ] Performed a self-review of my own code
- [ ] npm test passes on your machine
- [ ] New tests added or existing tests modified to cover all changes
- [ ] Code conforms with the style guide
- [ ] API Documentation in code was updated
- [ ] Any dependent changes have been merged and published in downstream
modules

Co-authored-by: TyagiSunny <[email protected]>
  • Loading branch information
Tyagi-Sunny and TyagiSunny authored Dec 6, 2023
1 parent 4c34a05 commit 1580fde
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Stage 1 - Create yarn install skeleton layer
FROM node:16 AS packages
FROM node:18 AS packages

WORKDIR /app
COPY package.json yarn.lock ./
Expand All @@ -11,7 +11,7 @@ COPY packages packages
RUN find packages \! -name "package.json" -mindepth 2 -maxdepth 2 -exec rm -rf {} \+

# Stage 2 - Install dependencies and build packages
FROM node:16 AS build
FROM node:18 AS build

ARG BASE_URL="http://localhost:7007"

Expand All @@ -26,7 +26,7 @@ RUN yarn tsc
RUN yarn --cwd packages/backend backstage-cli package build

# Stage 3 - Build the actual backend image and install production dependencies
FROM node:16-buster-slim
FROM node:18-buster-slim

WORKDIR /app

Expand Down
2 changes: 1 addition & 1 deletion packages/backend/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#
# Once the commands have been run, you can build the image using `yarn build-image`

FROM node:16-bullseye-slim
FROM node:18-bullseye-slim

# Install sqlite3 dependencies. You can skip this if you don't use sqlite3 in the image,
# in which case you should also move better-sqlite3 to "devDependencies" in package.json.
Expand Down

0 comments on commit 1580fde

Please sign in to comment.