-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins): validate user access for scaffold #157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validate user access for scaffold ARC-149
validate user access for scaffold ARC-149
Terraform plan output for poc
|
validate user access for scaffold ARC-149
validate user access for scaffold ARC-149
validate user access for scaffold ARC-149
validate user access for scaffold ARC-149
Quality Gate passedIssues Measures |
Terraform plan output for prod
|
Tyagi-Sunny
approved these changes
Jun 12, 2024
sadarunnisa-sf
requested review from
samarpan-b,
sfvishalgupta and
a-ganguly
and removed request for
vijay-stephen
June 12, 2024 14:24
a-ganguly
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validate user access for scaffold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict Repository Creation and Removal in Backstage to SF GitHub Users and Project Administrators
ARC-149
Description
Currently, anyone can create repositories in Backstage, which leads to several issues.
To resolve this issue, implemented solution as below.
Created github team in Sourcefuse organization. We can configure the team name by env var and SSM parameter.
Users with admin and member role from this team can scaffold the template and eventually repo would be created.
Other users would be able to view template list but won't be able to scaffold.
Made required changes in terraform code to add environment variables
Created custom backend plugin which would take care of validating user access.
Fixes # (issue)
#149
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: