Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a welcome screen with common tasks #554

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a welcome screen with common tasks #554

wants to merge 2 commits into from

Conversation

keynmol
Copy link
Contributor

@keynmol keynmol commented Apr 19, 2023

Let me know what you think.

Welcome banner when SBT is loaded with some commands from https://sourcegraph.github.io/scip-java/docs/contributing.html#helpful-commands being given helpful aliases.

These aliases survive wiping of SBT workspace because they're not part of history, but rather part of the build.

If desired, they can also be used in CI, as individual steps for better reporting, i.e. sbt --client gradleTests, sbt --client snapshotTests, etc.

image

Test plan

No testing required as the change is not functional.
Eyeballing CI output is enough.

Comment on lines +528 to +546
import sbtwelcome._

logo :=
raw"""
| _ _
| (_) (_)
| ___ ___ _ _ __ ______ _ __ ___ ____ _
| / __|/ __| | '_ \______| |/ _` \ \ / / _` |
| \__ \ (__| | |_) | | | (_| |\ V / (_| |
| |___/\___|_| .__/ | |\__,_| \_/ \__,_|
| | | _/ |
| |_| |__/
|
|${version.value}
|
|${scala.Console.YELLOW}Scala ${scalaVersion
.value}${scala.Console.RESET}
|
|""".stripMargin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, this block of code breaks scalafmt's idempotency, so it's going to be always broken :D

image

@olafurpg I won't risk upgrading scalafmt to a newer version until we don't have any more pressing PRs in flight.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scalafmt is such a fragile formatter can't imagine what ***** wrote this piece of software 🙈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:P

Entire Scala community is still looking for that rapscallion! He's going to get it once we find them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This person is doing a good job hiding in some corner

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not an exaggeration when I say that all the weirdly broken stuff in Scalafmt is my fault and if something works it's thanks to Albert (or some other contributor)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants